Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Add general usage Brave News P3A metrics (uplift to 1.68.x) #24366

Merged
merged 1 commit into from
Jun 25, 2024
Merged

[iOS] Add general usage Brave News P3A metrics (uplift to 1.68.x) #24366

merged 1 commit into from
Jun 25, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jun 25, 2024 •
edited by kjozwiak

Uplift of #24067
Resolves brave/brave-browser#38769

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner June 25, 2024 13:48
@brave-builds brave-builds added this to the 1.68.x - Beta milestone Jun 25, 2024
@brave-builds brave-builds self-assigned this Jun 25, 2024
@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Jun 25, 2024
@kylehickinson kylehickinson mentioned this pull request Jun 25, 2024
Closed
kjozwiak
kjozwiak approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.68.x approved 👍

@kjozwiak kjozwiak merged commit 1c6b4a8 into 1.68.x Jun 25, 2024
15 checks passed
@kjozwiak kjozwiak deleted the pr24067_ios-news-p3a_1.68.x branch June 25, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
1.68.x - Release
3 participants
@brave-builds @kjozwiak @kylehickinson