Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Japan installed Rewards now allows for BAT only in Add Funds dialog #2528

Merged
merged 1 commit into from
May 30, 2019
Merged

Japan installed Rewards now allows for BAT only in Add Funds dialog #2528

merged 1 commit into from
May 30, 2019

Conversation

jasonrsadler
Copy link
Contributor

@jasonrsadler jasonrsadler commented May 28, 2019 •
edited
Loading

@jasonrsadler jasonrsadler added this to the 0.66.x - Dev milestone May 28, 2019
@jasonrsadler jasonrsadler requested a review from a team May 28, 2019 20:03
@jasonrsadler jasonrsadler self-assigned this May 28, 2019
@kjozwiak
Copy link
Member

@jasonrsadler looks like the Jenkins passes have failed. Can you take a quick look and make sure that the failure isn't due to this particular PR?

@jasonrsadler
Copy link
Contributor Author

@kjozwiak yea, something's not right. There are some lint errors in files that are unrelated but it looks like it's not picking up correct UI hash.

kjozwiak
kjozwiak approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.66.x approved. Please ensure that the correct labels are being used and that the appropriate issue is moved into the correct milestone.

@jasonrsadler jasonrsadler merged commit a692f64 into 0.66.x May 30, 2019
@jasonrsadler jasonrsadler deleted the add-funds-jp-66 branch May 30, 2019 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@jasonrsadler jasonrsadler

Labels
feature/rewards
Projects
None yet
Milestone
0.66.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonrsadler @kjozwiak