Partially revert https://github.com/brave/brave-core/pull/4094 #4403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bsclifton okay to pull? |
bsclifton
approved these changes
Jan 22, 2020
|
Note to selves, as soon as #4269 lands, lets pull out the in-brave-core CSS rules and move them to another list in brave/adblock-lists (just to keep all the rules in one place and similarly editable / fast-pushable) |
32 tasks
|
Possible to uplift to release also @bsclifton ? |
This was referenced Feb 11, 2020
|
Added 1.5 milestone- this change is not in 1.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a few complaints of unskippable ads on
youtube.comNot an issue with a standard adblocker, since its enabled or not. Unskippable ads only occurs when a user disable site-trackers onyoutube.com.This is partial revert of 2 cosmetic filters from #4094