Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove main switch #6680

Merged
merged 16 commits into from
Oct 22, 2020
Merged

Remove main switch #6680

merged 16 commits into from
Oct 22, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Sep 22, 2020

Resolves brave/brave-browser#11467

Submitter Checklist:

Test Plan:

plan 1:

  • clean profile
  • open panel
  • make sure that there is no join rewards
  • open rewards page
  • make sure that there is no join rewards

plan 2:

  • clean profile
  • open panel
  • claim grant
  • make sure that it works correctly

plan 3:

  • claim grant
  • send a tip
  • make sure that tip is send correctly

plan 4:

  • switch to master branch
  • join rewards
  • enable ads and ac
  • disable rewards
  • switch to this branch
  • start browser
  • make sure that ads and ac are off

plan 5:

  • clean profile
  • open Task manager
  • make sure that there is no rewards extension, ledger or ads process

plan 6:

  • clean profile
  • connect to Uphold
  • make sure that you can connect successfully

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc self-assigned this Sep 22, 2020
@NejcZdovc NejcZdovc force-pushed the remove-main-switch branch 7 times, most recently from 838148d to 33c964f Compare September 28, 2020 08:24
@NejcZdovc NejcZdovc force-pushed the remove-main-switch branch 6 times, most recently from c61ee54 to d953e48 Compare October 8, 2020 06:13
@NejcZdovc NejcZdovc force-pushed the remove-main-switch branch 2 times, most recently from 8e989cf to b174ba5 Compare October 12, 2020 05:36
@NejcZdovc NejcZdovc marked this pull request as ready for review October 12, 2020 07:01
@NejcZdovc
Copy link
Contributor Author

PR is not complete yet, just running CI

@NejcZdovc NejcZdovc added CI/skip-android Do not run CI builds for Android CI/skip Do not run CI builds (except noplatform) labels Oct 12, 2020
@NejcZdovc NejcZdovc requested a review from a team as a code owner October 13, 2020 10:29
@NejcZdovc NejcZdovc removed the request for review from bridiver October 14, 2020 07:38
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

components/brave_ads/browser/ads_service_impl.h Outdated Show resolved Hide resolved
components/brave_ads/browser/ads_service_impl_unittest.cc Outdated Show resolved Hide resolved
components/brave_ads/browser/ads_service_impl_unittest.cc Outdated Show resolved Hide resolved
@NejcZdovc NejcZdovc force-pushed the remove-main-switch branch 2 times, most recently from 28bda4d to 5c669ea Compare October 21, 2020 09:34
@NejcZdovc NejcZdovc added this to the 1.18.x - Nightly milestone Oct 22, 2020
@NejcZdovc NejcZdovc removed the CI/skip-android Do not run CI builds for Android label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant rewards setting to address user confusion
7 participants