-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove main switch #6680
Merged
Merged
Remove main switch #6680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
remove-main-switch
branch
7 times, most recently
from
September 28, 2020 08:24
838148d
to
33c964f
Compare
NejcZdovc
force-pushed
the
remove-main-switch
branch
6 times, most recently
from
October 8, 2020 06:13
c61ee54
to
d953e48
Compare
NejcZdovc
force-pushed
the
remove-main-switch
branch
2 times, most recently
from
October 12, 2020 05:36
8e989cf
to
b174ba5
Compare
NejcZdovc
force-pushed
the
remove-main-switch
branch
from
October 12, 2020 07:01
b174ba5
to
bd53425
Compare
PR is not complete yet, just running CI |
NejcZdovc
force-pushed
the
remove-main-switch
branch
from
October 12, 2020 07:07
bd53425
to
cacf3bd
Compare
NejcZdovc
added
CI/skip-android
Do not run CI builds for Android
CI/skip
Do not run CI builds (except noplatform)
labels
Oct 12, 2020
NejcZdovc
force-pushed
the
remove-main-switch
branch
from
October 12, 2020 12:38
cacf3bd
to
a06fb01
Compare
NejcZdovc
force-pushed
the
remove-main-switch
branch
from
October 13, 2020 10:29
a06fb01
to
9e11d31
Compare
NejcZdovc
force-pushed
the
remove-main-switch
branch
from
October 20, 2020 09:39
88bc324
to
296881b
Compare
emerick
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zenparsing
approved these changes
Oct 20, 2020
tmancey
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
NejcZdovc
force-pushed
the
remove-main-switch
branch
2 times, most recently
from
October 21, 2020 09:34
28bda4d
to
5c669ea
Compare
NejcZdovc
force-pushed
the
remove-main-switch
branch
from
October 22, 2020 06:46
5c669ea
to
1c38425
Compare
Refactor code Refactor UI
NejcZdovc
force-pushed
the
remove-main-switch
branch
from
October 22, 2020 07:11
1c38425
to
1fd8b04
Compare
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#11467
Submitter Checklist:
npm run lint
,npm run gn_check
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
plan 1:
plan 2:
plan 3:
plan 4:
plan 5:
plan 6:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.