Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Wallet being blocked #7898

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Avoid Wallet being blocked #7898

merged 1 commit into from
Feb 9, 2021

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Feb 9, 2021

It was being blocked because the init was too early now that it's installed via an extension and not a component

Resolves brave/brave-browser#14068

Submitter Checklist:

  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)
  • Requested a security/privacy review as needed

Reviewer Checklist:

  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ lgtm

It was being blocked because the init was too early now that it's installed via an extension and not a component
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bbondy bbondy merged commit 91e62e5 into master Feb 9, 2021
@bbondy bbondy deleted the block-load-wallet branch February 9, 2021 23:46
@bbondy bbondy added this to the 1.22.x - Nightly milestone Feb 9, 2021
brave-builds pushed a commit that referenced this pull request Feb 9, 2021
brave-builds pushed a commit that referenced this pull request Feb 9, 2021
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.22.15 Chromium: 89.0.4389.40 (Official Build) nightly (64-bit)
Revision 2c2ed83cd507b23e4845edd09a7d1dfc727daf4b-refs/branch-heads/4389@{#602}
OS Linux
  • Verified enabling CW on 1.22.13 and setting CW to load at start cause it to break when browser is restarted
  • Verified upgrading to 1.22.15 doesn't cause CW to lock up/break when browser is restarted
  • Steps recorded here https://youtu.be/14tpdVM5n5c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet gets disabled on subsequent restarts now that it installs as an extension and not a component
6 participants