Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import file schemes correctly #9339

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Import file schemes correctly #9339

merged 1 commit into from
Jul 7, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jul 5, 2021

Resolves brave/brave-browser#16705

  • Import local files video/audio/images via file:/// scheme

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Clean profile 1.27.x
  2. Enable IPFS
  3. Use the Ctlr+O shortcut key and open any MP4 file from your local machine
  4. Right-click on the play icon and select Import to IPFS->Selected video option
  5. Getting IPFS import failed

@spylogsster spylogsster requested a review from bbondy July 5, 2021 18:37
@spylogsster spylogsster requested a review from a team as a code owner July 5, 2021 18:37
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@spylogsster spylogsster merged commit 5522bee into master Jul 7, 2021
@spylogsster spylogsster deleted the issue-16705 branch July 7, 2021 14:54
@spylogsster spylogsster added this to the 1.28.x - Nightly milestone Jul 7, 2021
@stephendonner
Copy link
Collaborator

Verified FIXED using the testplan above with build

Brave 1.28.64 Chromium: 92.0.4515.81 (Official Build) nightly (x86_64)
Revision dba3af0a9a48954c8b188bc641e651580b7cb7b5-refs/branch-heads/4515@{#1162}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. clean profile
  2. loaded ipns://brantly.eth and clicked on Use a local node
  3. used Ctlr+O shortcut key and opened sample-5s.mp4 from my local machine
  4. right-clicked on the play icon and selected Import to IPFS->Selected video option
  • Confirmed I got an alert notification letting me know the import had completed successfully, with a shareable link https://dweb.link/ipfs/QmYog8dP2hJpgQXvfFes6CfhT64fgzoksG4K3CPAt3PMFC?filename=sample-5s.mp4
  • Confirmed the file was copied into brave-imports
  • Confirmed the file was playable and intact
example example example example
Screen Shot 2021-07-08 at 3 00 05 PM Screen Shot 2021-07-08 at 3 00 10 PM Screen Shot 2021-07-08 at 3 00 13 PM Screen Shot 2021-07-08 at 3 00 18 PM

@spylogsster @bbondy I think this one is upliftable, given the fix is relatively small in size and scope; thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants