Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import file schemes correctly (uplift to 1.27.x) #9429

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Import file schemes correctly (uplift to 1.27.x) #9429

merged 1 commit into from
Jul 14, 2021

Conversation

brave-builds
Copy link
Collaborator

Uplift of #9339
Resolves brave/brave-browser#16705

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner July 14, 2021 09:14
@brave-builds brave-builds requested a review from a team July 14, 2021 09:14
@brave-builds brave-builds self-assigned this Jul 14, 2021
@brave-builds brave-builds added this to the 1.27.x - Beta milestone Jul 14, 2021
LaurenWags
LaurenWags approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.27.x is approved after deliberating with @brave/uplift-approvers

@LaurenWags LaurenWags merged commit d18d66c into 1.27.x Jul 14, 2021
@LaurenWags LaurenWags deleted the pr9339_issue-16705_1.27.x branch July 14, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenWags LaurenWags LaurenWags approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.27.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @LaurenWags @brave-browser-releases