-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android crash reports #9665
Android crash reports #9665
Conversation
1bc7b3c
to
e6babb2
Compare
e6babb2
to
08d626b
Compare
Added @jamesmudgett just to review the changes on screenshot at #9665 (comment) |
public class MinidumpUploader { | ||
/* package */ | ||
- static final String CRASH_URL_STRING = "https://clients2.google.com/cr/report"; | ||
+ static final String CRASH_URL_STRING = "https://cr.brave.com"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to make it with bytecode asm, but it didn't work.
My failed attempt is here d0a3909 .
If there is a way how to make that without patch, I will be happy to re-do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does your attempt generate build errors?
I suppose we can add changeFieldOwner
similar to changeMethodOwner
, maybe as a follow up as it is not related to this task directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, my best attempt did not generate a build error, just the actual url where crash dump was sent was the one from Google, actual url substitution didn't happen. And besides all I had to add two more new patches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a follow up issue with a brief description of the situation brave/brave-browser#17707
.
Header: Welcome to Brave cc @rmcfadden3 |
Send crash reports automatically | ||
</message> | ||
<message name="IDS_SEND_CRASH_REPORTS_SUMMARY" desc="Summary for checkbox of send crash reports automatically."> | ||
Crash reports helps Brave to improve stability of product. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @rmcfadden3 for wording suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samartnik , I have updated testcase for privacy settings at f839ab4 as we discussed in DM |
Will skip CI for now, because more changes / commits are required. |
Here are the examples of symbol file names as per build config:
|
As per security review the decision for now is:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
8f2a164
to
040858d
Compare
Rebased to the latest master and squashed some commits |
@anthonypkeane |
CI found pylint errors |
040858d
to
a1d11af
Compare
Fixed pylint errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for chromium_src (nice removal!), and possibly for the .patch file, but I'd defer to @samartnik for that.
Resolves brave/brave-browser#17563
This PR does introduces following changes:
Brave shields & privacy
namedSend crash reports automatically
;Help improve Brave by sending crash reports and completely anonymized, private product analytics
;https://cr.brave.com
;Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Test plan for developers:
npm run create_dist -- Release --target_os=android --target_arch=arm64 --target_android_base=mono --target_android_output_format=apk
;brave-browser/src/out/android_Release_arm64/dist/brave-v1.30.23-android-mono-arm64-symbols.zip
to backtrace.iohttps://brave.sp.backtrace.io/p/brave/settings/symbol/upload
Settings => Brave shields & privacy => Send crash reports automatically
;brave://inducebrowsercrashforrealz/
;brave://crashes
and ensure there is a crash report with statusUploaded
;Test plan for QA for the case when the symbols will be uploaded by CI
Settings => Brave shields & privacy => Send crash reports automatically
;brave://inducebrowsercrashforrealz/
;brave://crashes
and ensure there is a crash report with statusUploaded
;