Android crash reports #9665

AlexeyBarabash · 2021-08-05T14:20:55Z

Resolves brave/brave-browser#17563

This PR does introduces following changes:

Creates additional option in Brave shields & privacy named Send crash reports automatically;
Applies crash reporting settings from welcome screen message of Help improve Brave by sending crash reports and completely anonymized, private product analytics;
Makes the crash report be sent to our crash reporting endpoint, https://cr.brave.com;
Modifies the build script to generate breakpad symbols zip archive for Android libs ready for backtrace.io;

Submitter Checklist:

I confirm that no security/privacy review is needed, or that I have requested one - requested review at https://github.com/brave/security/issues/554
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Test plan for developers:

Build arm64 Mono Release apk:
npm run create_dist -- Release --target_os=android --target_arch=arm64 --target_android_base=mono --target_android_output_format=apk;
Upload symbols brave-browser/src/out/android_Release_arm64/dist/brave-v1.30.23-android-mono-arm64-symbols.zip to backtrace.io https://brave.sp.backtrace.io/p/brave/settings/symbol/upload
Install arm64 Mono APK on the device
Enable crash reporting in Settings => Brave shields & privacy => Send crash reports automatically;
Make a crash by open brave://inducebrowsercrashforrealz/;
Re-launch Brave;
Open page brave://crashes and ensure there is a crash report with status Uploaded;
Open https://brave.sp.backtrace.io/p/brave/explore?time=hour&filters=(plat%3DAndroid)&aggregations=((callstack%2Chead))& or use your search filters;
Ensure you can see your crash and the symbolized stack trace.

Test plan for QA for the case when the symbols will be uploaded by CI

Enable crash reporting in Settings => Brave shields & privacy => Send crash reports automatically;
Make a crash by open brave://inducebrowsercrashforrealz/;
Re-launch Brave;
Open page brave://crashes and ensure there is a crash report with status Uploaded;
Open https://brave.sp.backtrace.io/p/brave/explore?time=hour&filters=(plat%3DAndroid)&aggregations=((callstack%2Chead))&
Ensure you can see the symbolized stack trace.

AlexeyBarabash · 2021-08-19T15:24:53Z

Screenshot of welcome page which used to apply settings for crash reporting:

AlexeyBarabash · 2021-08-19T15:26:22Z

Screenshot of new setting in `Brave shields & privacy` settings:

AlexeyBarabash · 2021-08-19T15:44:08Z

Added @jamesmudgett just to review the changes on screenshot at #9665 (comment)

AlexeyBarabash · 2021-08-19T15:47:07Z

...oader-android-java-src-org-chromium-components-minidump_uploader-MinidumpUploader.java.patch

+ public class MinidumpUploader {
+     /* package */
+-    static final String CRASH_URL_STRING = "https://clients2.google.com/cr/report";
+    static final String CRASH_URL_STRING = "https://cr.brave.com";


I tried to make it with bytecode asm, but it didn't work.
My failed attempt is here d0a3909 .
If there is a way how to make that without patch, I will be happy to re-do.

Does your attempt generate build errors?
I suppose we can add changeFieldOwner similar to changeMethodOwner, maybe as a follow up as it is not related to this task directly.

No, my best attempt did not generate a build error, just the actual url where crash dump was sent was the one from Google, actual url substitution didn't happen. And besides all I had to add two more new patches.

Here is a follow up issue with a brief description of the situation brave/brave-browser#17707
.

AlexeyBarabash · 2021-08-19T15:49:41Z

The example of how it looks on backtrace.io is https://brave.sp.backtrace.io/p/brave/debug?time=(2021-07-19T18%3A48%2C2021-08-19T18%3A48)&filters=(plat%3DAndroid)&fingerprint=11660707ab256ea96b757a45aff5b37a5d0d474b471a459dbe9f97ec005b42c8&debug=(%2225886ca%22,0,0)

AlexeyBarabash · 2021-08-19T15:52:35Z

Screenshot of brave://crashes page with uploaded dumps list:

anthonypkeane · 2021-08-20T18:50:54Z

Screenshot of new setting in Brave shields & privacy settings:
@AlexeyBarabash

Header: Welcome to Brave
Body: Help improve Brave by automatically sending crash reports
Setting: Send crash reports and privacy-preserving product analytics
Button: Continue

cc @rmcfadden3

anthonypkeane · 2021-08-20T18:51:28Z

Screenshot of new setting in Brave shields & privacy settings:

Header 1: Allow privacy-preserving product analytics (P3A)
Body 1: Anonymized P3A info helps Brave estimate overall usage, and ensure we’re improving popular features.
Header 2: Automatically send crash reports
Body 2: Crash reports help Brave improve product stability for all users.

cc @AlexeyBarabash & @rmcfadden3

diracdeltas · 2021-08-21T02:43:17Z

browser/ui/android/strings/android_brave_strings.grd

+        Send crash reports automatically
+      </message>
+      <message name="IDS_SEND_CRASH_REPORTS_SUMMARY" desc="Summary for checkbox of send crash reports automatically.">
+        Crash reports helps Brave to improve stability of product.


cc @rmcfadden3 for wording suggestions

Updated words in
a635d47

Now it looks:

tools/android/generate_breakpad_symbols.py

AlexeyBarabash · 2021-08-25T12:06:14Z

@samartnik , I have updated testcase for privacy settings at f839ab4 as we discussed in DM

AlexeyBarabash · 2021-08-25T17:37:14Z

Will skip CI for now, because more changes / commits are required.

AlexeyBarabash · 2021-08-26T14:32:57Z

Here are the examples of symbol file names as per build config:

Package name	Symbols file
Bravearm.apk	brave-v1.30.33-android-classic-arm-symbols.zip
BraveMonoarm.apk	brave-v1.30.33-android-mono-arm-symbols.zip
BraveMonoarm64.apk	brave-v1.30.33-android-mono-arm64-symbols.zip
BraveMonox64.apk	brave-v1.30.33-android-mono-x64-symbols.zip
BraveMonox86.apk	brave-v1.30.33-android-mono-x86-symbols.zip
Bravex86.apk	brave-v1.30.33-android-classic-x86-symbols.zip

AlexeyBarabash · 2021-08-27T09:34:22Z

As per security review the decision for now is:

Modify the welcome page
Help improve Brave by sending crash reports and completely anonymized, private product analytics.
=>
Help improve Brave by sending completely anonymized, private product analytics.
remove the mention of analytics, as right now in master this checkbox doesn't affect on the actual crash reporting
In the Privacy preferences make option Automatically send crash reports be false by default.

samartnik

lgtm

fixes brave/brave-browser#17563

AlexeyBarabash · 2021-08-27T15:42:32Z

Rebased to the latest master and squashed some commits

AlexeyBarabash · 2021-08-27T15:52:48Z

@anthonypkeane
Here is updated screens after privacy review comments:

AlexeyBarabash · 2021-08-28T11:05:34Z

CI found pylint errors

AlexeyBarabash · 2021-08-30T12:41:20Z

Fixed pylint errors

mariospr

LGTM for chromium_src (nice removal!), and possibly for the .patch file, but I'd defer to @samartnik for that.

AlexeyBarabash self-assigned this Aug 5, 2021

AlexeyBarabash added the CI/skip Do not run CI builds (except noplatform) label Aug 5, 2021

AlexeyBarabash force-pushed the android_crash_reports branch 5 times, most recently from 1bc7b3c to e6babb2 Compare August 19, 2021 10:57

AlexeyBarabash added enhancement and removed CI/skip Do not run CI builds (except noplatform) labels Aug 19, 2021

AlexeyBarabash marked this pull request as ready for review August 19, 2021 15:33

AlexeyBarabash requested review from samartnik and a team as code owners August 19, 2021 15:33

AlexeyBarabash force-pushed the android_crash_reports branch from e6babb2 to 08d626b Compare August 19, 2021 15:42

AlexeyBarabash requested review from SergeyZhukovsky, wchen342, alexsafe and jamesmudgett August 19, 2021 15:43

AlexeyBarabash commented Aug 19, 2021

View reviewed changes

diracdeltas reviewed Aug 21, 2021

View reviewed changes

wchen342 reviewed Aug 21, 2021

View reviewed changes

tools/android/generate_breakpad_symbols.py Outdated Show resolved Hide resolved

AlexeyBarabash added the CI/skip Do not run CI builds (except noplatform) label Aug 25, 2021

AlexeyBarabash mentioned this pull request Aug 26, 2021

[Android] Investigate asm bytecode patching for static const fields brave/brave-browser#17707

Open

samartnik approved these changes Aug 27, 2021

View reviewed changes

Removed BraveCrashpadClient override to keep upload url empty

8369187

AlexeyBarabash requested a review from mihaiplesa August 27, 2021 15:13

AlexeyBarabash added 3 commits August 27, 2021 18:25

UI option for auto sending crash reports on Android

71f90c0

fixes brave/brave-browser#17563

Updated java test for additional privacy menu item

e401e4f

Modified endpoint url for Android crash reporting

275267d

AlexeyBarabash removed the CI/skip Do not run CI builds (except noplatform) label Aug 27, 2021

AlexeyBarabash force-pushed the android_crash_reports branch from 8f2a164 to 040858d Compare August 27, 2021 15:40

AlexeyBarabash added 2 commits August 30, 2021 15:39

Generating breakpad symbols for Android libs

2fc4fb4

Fixed welcome message to say nothing about crash reports

a1d11af

AlexeyBarabash force-pushed the android_crash_reports branch from 040858d to a1d11af Compare August 30, 2021 12:40

mariospr approved these changes Aug 31, 2021

View reviewed changes

AlexeyBarabash merged commit 3e373db into master Aug 31, 2021

AlexeyBarabash deleted the android_crash_reports branch August 31, 2021 17:10

AlexeyBarabash added this to the 1.31.x - Nightly milestone Aug 31, 2021

srirambv mentioned this pull request Oct 5, 2021

Make Android send crash reports to backtrace.io brave/brave-browser#17563

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android crash reports #9665

Android crash reports #9665

AlexeyBarabash commented Aug 5, 2021 •

edited

AlexeyBarabash commented Aug 19, 2021

AlexeyBarabash commented Aug 19, 2021

AlexeyBarabash commented Aug 19, 2021

AlexeyBarabash Aug 19, 2021

samartnik Aug 19, 2021

AlexeyBarabash Aug 19, 2021

AlexeyBarabash Aug 26, 2021 •

edited

AlexeyBarabash commented Aug 19, 2021

AlexeyBarabash commented Aug 19, 2021

anthonypkeane commented Aug 20, 2021

anthonypkeane commented Aug 20, 2021

diracdeltas Aug 21, 2021

AlexeyBarabash Aug 25, 2021

AlexeyBarabash commented Aug 25, 2021

AlexeyBarabash commented Aug 25, 2021

AlexeyBarabash commented Aug 26, 2021 •

edited

AlexeyBarabash commented Aug 27, 2021

samartnik left a comment

AlexeyBarabash commented Aug 27, 2021

AlexeyBarabash commented Aug 27, 2021

AlexeyBarabash commented Aug 28, 2021

AlexeyBarabash commented Aug 30, 2021

mariospr left a comment

Android crash reports #9665

Android crash reports #9665

Conversation

AlexeyBarabash commented Aug 5, 2021 • edited

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

AlexeyBarabash commented Aug 19, 2021

AlexeyBarabash commented Aug 19, 2021

AlexeyBarabash commented Aug 19, 2021

AlexeyBarabash Aug 19, 2021

Choose a reason for hiding this comment

samartnik Aug 19, 2021

Choose a reason for hiding this comment

AlexeyBarabash Aug 19, 2021

Choose a reason for hiding this comment

AlexeyBarabash Aug 26, 2021 • edited

Choose a reason for hiding this comment

AlexeyBarabash commented Aug 19, 2021

AlexeyBarabash commented Aug 19, 2021

anthonypkeane commented Aug 20, 2021

anthonypkeane commented Aug 20, 2021

diracdeltas Aug 21, 2021

Choose a reason for hiding this comment

AlexeyBarabash Aug 25, 2021

Choose a reason for hiding this comment

AlexeyBarabash commented Aug 25, 2021

AlexeyBarabash commented Aug 25, 2021

AlexeyBarabash commented Aug 26, 2021 • edited

AlexeyBarabash commented Aug 27, 2021

samartnik left a comment

Choose a reason for hiding this comment

AlexeyBarabash commented Aug 27, 2021

AlexeyBarabash commented Aug 27, 2021

AlexeyBarabash commented Aug 28, 2021

AlexeyBarabash commented Aug 30, 2021

mariospr left a comment

Choose a reason for hiding this comment

AlexeyBarabash commented Aug 5, 2021 •

edited

AlexeyBarabash Aug 26, 2021 •

edited

AlexeyBarabash commented Aug 26, 2021 •

edited