Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Investigate asm bytecode patching for static const fields #17707

Open
AlexeyBarabash opened this issue Aug 26, 2021 · 0 comments
Open

[Android] Investigate asm bytecode patching for static const fields #17707

AlexeyBarabash opened this issue Aug 26, 2021 · 0 comments
Assignees
@samartnik
Labels
enhancement OS/Android Fixes related to Android browser functionality

Comments

@AlexeyBarabash
Copy link
Contributor

This is follow up from brave/brave-core#9665, brave/brave-core#9665 (comment) .

Patching through creating of the subclass with re-difining Chromium field for me led to the situation when actually the Chromium's value was used, not the Brave's one.

If it is possible that could simplify patching,

Required to be investigated.
@AlexeyBarabash AlexeyBarabash added enhancement OS/Android Fixes related to Android browser functionality labels Aug 26, 2021
@AlexeyBarabash AlexeyBarabash mentioned this issue Aug 26, 2021
Merged
24 tasks
@samartnik samartnik self-assigned this Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
enhancement OS/Android Fixes related to Android browser functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexeyBarabash @samartnik