Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Progress bar UX update #3892

Closed
anthonypkeane opened this issue Jul 6, 2021 · 1 comment · Fixed by #3893
Closed

Progress bar UX update #3892

anthonypkeane opened this issue Jul 6, 2021 · 1 comment · Fixed by #3893

Comments

@anthonypkeane
Copy link

Description:

Link: https://bravesoftware.slack.com/archives/C06UXF3KJ/p1622509944112800

In iOS brave it seems like we don’t get a progress bar until the first byte of the HTML response has been received. This is different from Safari, where you get the initial ~10% of the progress bar filled once the request has been issued. To my experience, the Safari approach feel nicer, since if you’re in a really slow network situation, clicking on links seems to do nothing at all for a while, making it seem like the browser has locked up.

@kylehickinson kylehickinson self-assigned this Jul 6, 2021
kylehickinson added a commit that referenced this issue Jul 6, 2021
Since `WKWebView.estimatedProgress` is a Double, the cast to a `Float` was failing when the value was 0.1 for unknown reasons. Most likely something to do with the bridging between `NSNumber` and `Float` when the underlying value stored in the `NSNumber` is a `Double`
@anthonypkeane anthonypkeane added this to the 1.29 milestone Jul 6, 2021
kylehickinson added a commit that referenced this issue Jul 7, 2021
Since `WKWebView.estimatedProgress` is a Double, the cast to a `Float` was failing when the value was 0.1 for unknown reasons. Most likely something to do with the bridging between `NSNumber` and `Float` when the underlying value stored in the `NSNumber` is a `Double`
@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 13.5 running 1.29(21.7.20.16)


Verification passed on iPhone 7+ with iOS 14.5.1 running 1.29(21.7.20.16)


Verification passed on iPad Pro with iOS 14.6 running 1.29(21.7.20.16)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.