Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Hide or Alter 'Favorites' Label in Absence of Favorites #4128

Closed
jonathansampson opened this issue Sep 2, 2021 · 1 comment · Fixed by #4152
Closed

Hide or Alter 'Favorites' Label in Absence of Favorites #4128

jonathansampson opened this issue Sep 2, 2021 · 1 comment · Fixed by #4152

Comments

@jonathansampson
Copy link
Contributor

Description:

If there are no favorites to show, hide (or perhaps alter) the "Favorites" label when the user focuses the address bar.

Steps to Reproduce

  1. Delete all favorites via long-press on NTP favicons
  2. Focus address bar

Actual result:
Note "Favorites" Label is shown without any favorites beneath.

Expected result:
No label, or perhaps "No favorites" shown instead. The latter could still be confusing for users.

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy.

Brave Version:
1.30.1

Additional Information

Reported on Twitter.
image

@srirambv
Copy link
Contributor

Verification passed on iPhone 7+ with iOS 14.8 running 1.32.1(21.10.18.10)
With Favourites Without Favourites Without recent search history
image image image

Verification passed on iPhone XR with iOS 15.0.1 running 1.32.1(21.10.18.10)
With Favourites Without Favourites Without recent search history
image image image

Verification passed on iPad Pro with iOS 15.1 Beta 3 running 1.32.1(21.10.18.10)
With Favourites Without Favourites Without recent search history
image image image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.