This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #4128: Hide 'Favorites' section in absence of favorites #4152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Only create the favorites section in the collectionView in FavoritesViewController if the user actually has favorites
This pull request fixes #4128
Submitter Checklist:
NSLocalizableString()
Test Plan:
Screenshots:
With no favorites:
With favorites:
No favorites, hidden search history - is it okay that the view is essentially empty in this scenario?
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement