Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #4128: Hide 'Favorites' section in absence of favorites #4152

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

dooost
Copy link
Contributor

@dooost dooost commented Sep 11, 2021

Summary of Changes

Only create the favorites section in the collectionView in FavoritesViewController if the user actually has favorites

This pull request fixes #4128

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Open a new tab
  • Remove all favorites by long pressing on it
  • The "Favorites" header should disappear
  • Show/hide search history and verify they appear as expected
  • Add/remove text to pasteboard and verify the 'Paste & Go' button appears as expected

Screenshots:

With no favorites:
Screenshot 2021-09-11 at PM 11 32 00

With favorites:
Screenshot 2021-09-11 at PM 11 32 47

No favorites, hidden search history - is it okay that the view is essentially empty in this scenario?
Screenshot 2021-09-11 at PM 11 33 22

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@iccub iccub added this to the 1.32 milestone Sep 13, 2021
@iccub iccub self-requested a review September 13, 2021 14:50
Copy link
Contributor

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, very clean PR :)

@iccub iccub merged commit 048289a into brave:development Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide or Alter 'Favorites' Label in Absence of Favorites
2 participants