Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Better handle private key and recovery phrases when the user copies them #4613

Closed
kylehickinson opened this issue Dec 2, 2021 · 1 comment
Closed

Better handle private key and recovery phrases when the user copies them #4613

kylehickinson opened this issue Dec 2, 2021 · 1 comment
Assignees
@kylehickinson
Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.33

Comments

@kylehickinson
Copy link
Collaborator

kylehickinson commented Dec 2, 2021 •
edited
Loading

Description:

We have copy buttons on the recovery phrase backup screens and the account private key screen, we should ensure that when this data is copied to the users pasteboard it is excluded from handoff and it expires after a given time (currently: 60s, but may change)

Pending investigation but: We should also clear the users pasteboard if they successfully import a secondary account with a private key
@kylehickinson kylehickinson added this to the 1.33 milestone Dec 2, 2021
@kylehickinson kylehickinson self-assigned this Dec 2, 2021
kylehickinson added a commit that referenced this issue Dec 2, 2021
@kylehickinson
Fix #4613: Make private key and recovery phrase copy to clipboard secure
651d9be
kylehickinson added a commit that referenced this issue Dec 2, 2021
@kylehickinson
Fix #4613: Make private key and recovery phrase copy to clipboard secure
8c07ee6
kylehickinson added a commit that referenced this issue Dec 3, 2021
@kylehickinson
Fix #4613: Make private key and recovery phrase copy to clipboard secure
104af11
@kylehickinson kylehickinson mentioned this issue Dec 3, 2021
Merged
7 tasks
kylehickinson added a commit that referenced this issue Dec 3, 2021
@kylehickinson
Fix #4613: Make private key and recovery phrase copy to clipboard secure
3e471bb
iccub pushed a commit that referenced this issue Dec 3, 2021
@kylehickinson
Fix #4613: Make private key and recovery phrase copy to clipboard sec…
867d13a 
…ure (#4624)
@srirambv
Copy link
Contributor

Verification passed on iPhone 7+ with iOS 14.8.1 running 1.33 (21.12.9.23)

  • Verified steps from issue description
  • Verified private key copied to clipboard is cleared after 60 secs
  • Verified recovery seed copied to clipboard is cleared after 60 secs
  • Verified copying a private key to clipboard and importing it as secondary account clears the clipboard after 60 secs
  • Verified copying seed words to restore wallet clears the clipboard after 60 secs
  • Verified copying random 12 words to clipboard doesn't clear it when trying to restore using it

Verification passed on iPhone XR with iOS 15.1 running 1.33 (21.12.9.23)

  • Verified steps from issue description
  • Verified private key copied to clipboard is cleared after 60 secs
  • Verified recovery seed copied to clipboard is cleared after 60 secs
  • Verified copying a private key to clipboard and importing it as secondary account clears the clipboard after 60 secs
  • Verified copying seed words to restore wallet clears the clipboard after 60 secs
  • Verified copying random 12 words to clipboard doesn't clear it when trying to restore using it

Verification passed on iPad Pro with iOS 15.2 running 1.33 (21.12.9.23)

  • Verified steps from issue description
  • Verified private key copied to clipboard is cleared after 60 secs
  • Verified recovery seed copied to clipboard is cleared after 60 secs
  • Verified copying a private key to clipboard and importing it as secondary account clears the clipboard after 60 secs
  • Verified copying seed words to restore wallet clears the clipboard after 60 secs
  • Verified copying random 12 words to clipboard doesn't clear it when trying to restore using it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.33
Development

No branches or pull requests
2 participants
@kylehickinson @srirambv