Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Clearing recent searches does not update UI and is hard to tap #4923

Closed
kylehickinson opened this issue Jan 31, 2022 · 2 comments · Fixed by #7864
Closed

Clearing recent searches does not update UI and is hard to tap #4923

kylehickinson opened this issue Jan 31, 2022 · 2 comments · Fixed by #7864

Comments

@kylehickinson
Copy link
Collaborator

kylehickinson commented Jan 31, 2022

Description:

The "clear" button on recent searches does not update the UI after using it. It's hit box is also too small and is difficult to tap

The clear button is too far from the edge as well

Steps to Reproduce

  1. Search with the Recent Searches preference enabled
  2. Open a new tab and tap on the URL bar
  3. Tap clear, and then "Clear Recent" when the action sheet appears

Actual result: Recent searches stay visible

Expected result: Recent searches should be removed from the list

Reproduces how often: Always

Brave Version: 1.34.1 Live

RPReplay_Final1643667784.MP4
@Brandon-T
Copy link
Collaborator

Should be fixed by: #4901
Will double check and also check the hard to tap issue.

Brandon-T added a commit that referenced this issue Aug 11, 2023
- Fix hit test on recent search buttons
@iccub iccub added this to the 1.57 milestone Aug 16, 2023
@hffvld
Copy link
Collaborator

hffvld commented Aug 17, 2023

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: 
- iPhone 14 [iOS 16.6]
- iPad Air [iPadOS 16.5]
Brave build: 1.57 (23.8.16.21)
BraveCore: 1.57.47 (116.0.5845.96)

STEPS:

  1. Launch Brave
  2. Tap on Search bar > Tap Show Recent Searches
  3. Search anything
  4. Open NTP > Tap on Search bar > Tap Clear
  5. Clear Recent > Verify

ACTUAL RESULTS:

  • Verified that Cear Recent is working, and search results are removed
  • Verified that it's easy to tap on buttons to clear search results
  • Verified that Cancel button is working
  • Verified that tapping on a previous search result is opening actual search results

iPhone

Search.mov

iPad

Search.ipad.mov

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.