Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

No Bug: Remove swiftlint step from gh actions #3200

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Jan 14, 2021

Swiftlint is now preinstalled on macOS instances.
https://github.com/actions/virtual-environments/blob/main/images/macos/macos-10.15-Readme.md#linters

Without this change I see following error in logs, it started to happen today

The formula built, but is not symlinked into /usr/local
Could not symlink bin/swiftlint
Target /usr/local/bin/swiftlint
already exists. You may want to remove it:
  rm '/usr/local/bin/swiftlint'

Summary of Changes

This pull request fixes #

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

Swiftlint is now preinstalled on macOS instances.
@iccub iccub added this to the 1.23 milestone Jan 14, 2021
@iccub iccub merged commit a162177 into development Jan 14, 2021
@iccub iccub deleted the nobug/update_gh_actions_swiftlint branch January 14, 2021 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants