Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Update BraveCore library to 1.19.x #3261

Merged
merged 4 commits into from
Feb 5, 2021
Merged

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Feb 3, 2021

Summary of Changes

This pull request fixes #3269
This pull request fixes #3188
This pull request fixes #3195

Switches to XCFrameworks:

  • Replaces FAT frameworks in the project with XCFrameworks
  • Removes dSYM copy since dSYMS will be bundles inside the XCFrameworks
  • Updates build_in_core script to make XCFrameworks instead of FAT frameworks
  • Removes last usage of Carthage

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@iccub
Copy link
Contributor

iccub commented Feb 5, 2021

Do you think we should have separate ticket for brave-core updates? Usually QA wants to have a larger scope of tests when we update it

@kylehickinson
Copy link
Collaborator Author

@iccub We can open a 1.19.x update specific issue and just list that QA should sanity test rewards & sync

@kylehickinson kylehickinson linked an issue Feb 5, 2021 that may be closed by this pull request
@kylehickinson kylehickinson merged commit e4807bb into development Feb 5, 2021
@kylehickinson kylehickinson deleted the brave-core-1.19.x branch February 5, 2021 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Brave Core library to 1.19.x [Sync] Delete Other Devices Support Support Rewards Everywhere
3 participants