Fix #3327: Remove stale sync v1 code, rename old 'Bookmarks' to 'Favorites'

[iccub]

Summary of Changes

This pull request fixes #3327

Submitter Checklist:

• Unit Tests are updated to cover new or changed functionality
• User-facing strings use NSLocalizableString()

Test Plan:

3 Basic tests would be nice to have, they don't have to be really thorough

1. Test that sync is working
2. Test that migration from pre sync-v2 is working, can be basic test just to verify that old bookmarks got migrated correctly.
3. Test that non-sync bookmarks and favorites behavior works: add, create, update, delete, reorder

Screenshots:

Reviewer Checklist:

• Issues include necessary QA labels:
  • QA/(Yes|No)
  • release-notes/(include|exclude)
  • bug / enhancement
• Necessary security reviews have taken place.
• Adequate unit test coverage exists to prevent regressions.
• Adequate test plan exists for QA to validate (if applicable).
• Issue is assigned to a milestone (should happen at merge time).

[kylehickinson]

So just to clarify:

Bookmark is still the entity in CoreData, but its NSManagedObject subclass is named Favourite, and a bunch of the old Chromium bookmark migration stuff was moved to LegacyBookmark?

[iccub]

Yes @kylehickinson

1. Bookmark renamed to Favorite, no migration required, but we can migrate if we want to, removed unused properties etc
2. Methods that still rely on old Bookmark code were moved to LegacyBookmark, which is the same class as Favorite, added for readability reasons. At the moment only chromium migration and older 1.12, 1.7 migration/restoration code still uses core-data bookmarks.
3. Most notable change in Bookmark/Favorite code is going back to using order instead of syncOrder, besides that most of the work is removing unused code or unused properties from code if possible, for fields like isFolder isFavorite parentFolder