This repository has been archived by the owner on May 10, 2024. It is now read-only.
Ref #3109, Fix #3310: Update Translations #3309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccub
approved these changes
Feb 12, 2021
| @@ -8,7 +8,7 @@ | |||
| "BraveRewardsAdNotificationTitle" = "Brave Rewards"; | |||
|
|
|||
| /* No comment provided by engineer. */ | |||
| "BraveRewardsOpen" = "Otwórz"; | |||
| "BraveRewardsOpen" = "Otwarte"; | |||
There was a problem hiding this comment.
this reviewed string is actually incorrect, i should do Polish translations manually at some point, there's few places with incorrect words :D nothing to do here now
There was a problem hiding this comment.
Hah, both translations are bad?
There was a problem hiding this comment.
first one is correct, in Poland Open can mean 2 things, 2 slightly different words depending on context
- Open as 'a shop is open'
- Open as 'open Brave Rewards panel'
soner-yuksel
approved these changes
Feb 12, 2021
Brandon-T
approved these changes
Feb 12, 2021
kylehickinson
changed the title
kylehickinson
added a commit
that referenced
this pull request
Feb 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request references #3109
This pull request fixes #3310
Submitter Checklist:
NSLocalizableString()Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement