Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #3870: Add 1.28 translations. #3876

Merged
merged 1 commit into from Jul 2, 2021
Merged

Fix #3870: Add 1.28 translations. #3876

merged 1 commit into from Jul 2, 2021

Conversation

iccub
Copy link
Collaborator

@iccub iccub commented Jul 2, 2021 •
edited

Summary of Changes

This pull request fixes #3870

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Verify that the Data saved per domain in Japan popup is translated.

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@iccub iccub added this to the 1.28 milestone Jul 2, 2021
@iccub iccub merged commit 65c8000 into development Jul 2, 2021
@iccub iccub deleted the bugfix/3870 branch July 2, 2021 17:06
iccub added a commit that referenced this pull request Jul 2, 2021
@iccub
Fix #3870: Add 1.28 translations. (#3876)
e461c18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylehickinson kylehickinson kylehickinson approved these changes

@soner-yuksel soner-yuksel Awaiting requested review from soner-yuksel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.28
Development

Successfully merging this pull request may close these issues.

Add 1.28 translations
2 participants
@iccub @kylehickinson