Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

No Bug: Import 1.39 localizations into new directories + files #5457

Merged
merged 1 commit into from
Jun 7, 2022
Merged

No Bug: Import 1.39 localizations into new directories + files #5457

merged 1 commit into from
Jun 7, 2022

Conversation

kylehickinson
Copy link
Collaborator

Summary of Changes

Refs #5435

Takes the changes here and applies them to the new locations

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson requested a review from iccub June 7, 2022 17:00
iccub
iccub approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran this branch with Polish language and translations work nicely

@kylehickinson kylehickinson merged commit df1cd0f into development Jun 7, 2022
@kylehickinson kylehickinson deleted the pull-in-translations branch June 7, 2022 17:18
@kylehickinson kylehickinson added this to the 1.40 milestone Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iccub iccub iccub approved these changes

Assignees
No one assigned
Labels
QA/No
Projects
None yet
Milestone
1.40
Development

Successfully merging this pull request may close these issues.
2 participants
@kylehickinson @iccub