Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Recovery keys fail both manual/import #11293

Closed
srirambv opened this issue Oct 5, 2017 · 2 comments
Closed

Recovery keys fail both manual/import #11293

srirambv opened this issue Oct 5, 2017 · 2 comments
Assignees
@NejcZdovc
Labels
bug feature/rewards priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Oct 5, 2017 •
edited by luixxiul
Loading

Test plan

See below

Description

Recovery keys fail both manual/import

Steps to Reproduce

  1. Build from 2ca8815
  2. Enable payments and save recovery key
  3. Clear profile and launch new one
  4. Enable payments and import recovery keys from step 2
  5. Recovery fails

Actual result:

image

Expected result:
Should import successfully
Reproduces how often: [What percentage of the time does it reproduce?]

Brave Version

about:brave info:

Brave 0.21.0
V8 6.1.534.41
rev 2ca8815
Muon 4.4.25

Reproducible on current live release:

Additional Information
@srirambv srirambv added this to the 0.19.x (Beta Channel) milestone Oct 5, 2017
@NejcZdovc NejcZdovc added the priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. label Oct 5, 2017
@NejcZdovc NejcZdovc self-assigned this Oct 5, 2017
@NejcZdovc
Copy link
Contributor

fixed with #11231

@NejcZdovc NejcZdovc mentioned this issue Oct 5, 2017
Merged
8 tasks
@ghost ghost added priority/P3 Major loss of function. and removed priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. labels Oct 6, 2017
@ghost
Copy link

ghost commented Oct 6, 2017

Adjusting priority:

  • P1 - Blocks development or testing. Product cannot run.
  • P2 - Crashes. Loss of data. Severe memory leak.
  • P3 - Major loss of function.
  • P4 - Minor loss of function. Workaround usually present.
  • P5 - Cosmetic. Spelling, copy, layout.

NejcZdovc added a commit that referenced this issue Oct 6, 2017
@NejcZdovc
Adds BAT support
5813411 
Resolves #9740
Resolves #10945
Resolves #11251 
Resolves #11264
Resolves #11285
Resolves #11289
Resolves #11292
Resolves #11293
This was referenced Oct 9, 2017
Closed
Closed
Closed
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@NejcZdovc @syuan100
Adds BAT support
f9990fd 
Resolves brave#9740
Resolves brave#10945
Resolves brave#11251 
Resolves brave#11264
Resolves brave#11285
Resolves brave#11289
Resolves brave#11292
Resolves brave#11293
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/rewards priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
4 participants
@kjozwiak @luixxiul @NejcZdovc @srirambv