Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

YouTube videos lag/stop working #13079

Closed
LaurenWags opened this issue Feb 9, 2018 · 6 comments · Fixed by #13234
Closed

YouTube videos lag/stop working #13079

LaurenWags opened this issue Feb 9, 2018 · 6 comments · Fixed by #13234
Assignees
@petemill
Labels
bug perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x Release 3 ...

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Feb 9, 2018 •
edited by kjozwiak
Loading

Test Plan

Description

Reported via twitter: https://twitter.com/glaucocustodio/status/961728287990042624 and internally by @NejcZdovc

YouTube is lagging after viewing for some time and/or having multiple tabs open. @NejcZdovc noticed that if he clicks the video lags - and if he clicks continuously the video stops working until he stops clicking.

Test plan / Steps to Reproduce

  1. start browser (make sure you have a folder with at least 20 bookmarks)
  2. open YouTube player
  3. right click on a folder and select Open all in tabs
  4. then immediately after they are opened start closing them with mouse middle button (rapidly)
  5. youtube starts lagging and then if you just click on a youtube page (on white section) video lags
    note: if you don't experience the issue after the first try, go to step 3 and repeat from there

Actual result:
Video lags, especially when clicking anywhere in the whitespace of the page. Errors are generated in the main browser console (not the window's console):

An uncaught exception occurred in the main process Uncaught Exception:
param str (null) is not a string

Expected result:
Video should not lag.

Reproduces how often:
unknown

Brave Version

about:brave info:
0.20.30

Reproducible on current live release:
yes

Additional Information
@LaurenWags LaurenWags added the bug label Feb 9, 2018
@LaurenWags LaurenWags mentioned this issue Feb 9, 2018
Closed
@mr2cats
Copy link

mr2cats commented Feb 10, 2018

Same problem. It appeared with the last update for me.

@luixxiul luixxiul added the perf label Feb 11, 2018
@LaurenWags
Copy link
Member Author

+1 from @bbondy - seems to occur at the same time as #12333 #12828 and #13157

maybe related @bsclifton ?

@petemill
Copy link
Member

STR from @NejcZdovc as provided in #13087 :

  1. start browser (make sure you have a folder with at least 20 bookmarks)
  2. open YouTube player
  3. right click on a folder and select Open all in tabs
  4. then immediately after they are opened start closing them with mouse middle button or cmd+w
  5. youtube starts lagging and then if you just click on a youtube page (on white section) video lags

petemill added a commit that referenced this issue Feb 21, 2018
@petemill
Prevent null key in historySites state
95394b9 
This was causing an error to be thrown for every subsequent action, and no more state updates to be sent to windows, resulting in multiple issues.
It was also causing an error dump to be generated upon every action, thus halting the browser at those times, including any audio/video (and creating stutters).

Fix #13079 (main test case with STR)
Fix #12333
Fix #12828
Fix #13157
Address #13087 but this is a broad issue - this change will fix a hard issue, whereas that refers to general slowness.
@petemill petemill mentioned this issue Feb 21, 2018
Merged
10 tasks
@bsclifton bsclifton added this to the 0.21.x (Beta Channel) milestone Feb 21, 2018
bsclifton pushed a commit that referenced this issue Feb 21, 2018
@petemill @bsclifton
Prevent null key in historySites state
801b44b 
This was causing an error to be thrown for every subsequent action, and no more state updates to be sent to windows, resulting in multiple issues.
It was also causing an error dump to be generated upon every action, thus halting the browser at those times, including any audio/video (and creating stutters).

Fix #13079 (main test case with STR)
Fix #12333
Fix #12828
Fix #13157
Address #13087 but this is a broad issue - this change will fix a hard issue, whereas that refers to general slowness.
@srirambv
Copy link
Collaborator

Verified on 0.21.12 no lag on video playback based on the test plan

@bsclifton bsclifton modified the milestones: 0.22.x (Developer Channel), 0.20.x Release 3 (Hotfix) Feb 25, 2018
@kjozwiak
Copy link
Member

Clearing QA/checked tags as this is now landing in 0.20.x for the hotfix. We should recheck against all there platforms and make sure things are still working as expected.

@riastradh-brave riastradh-brave mentioned this issue Feb 25, 2018
Closed
This was referenced Feb 25, 2018
Closed
Closed
This was referenced Feb 26, 2018
Closed
Closed
Closed
@petemill
Copy link
Member

This did not just affect youtube, but all video / audio media playback, and probably also anything the tab may be running in JS, whilst the browser created a crash report upon every click (or other action)

@kjozwiak kjozwiak mentioned this issue Feb 26, 2018
Closed
ryanml pushed a commit to ryanml/browser-laptop that referenced this issue Feb 27, 2018
@petemill @ryanml
Prevent null key in historySites state
0ef3e46 
This was causing an error to be thrown for every subsequent action, and no more state updates to be sent to windows, resulting in multiple issues.
It was also causing an error dump to be generated upon every action, thus halting the browser at those times, including any audio/video (and creating stutters).

Fix brave#13079 (main test case with STR)
Fix brave#12333
Fix brave#12828
Fix brave#13157
Address brave#13087 but this is a broad issue - this change will fix a hard issue, whereas that refers to general slowness.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petemill petemill

Labels
bug perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x Release 3 (Hotfix)
Development

Successfully merging a pull request may close this issue.

Prevent null key in historySites state brave/browser-laptop
8 participants
@petemill @kjozwiak @luixxiul @bsclifton @srirambv @LaurenWags @mr2cats @btlechowski