Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

sometimes back button stops working until restart #13157

Closed
LaurenWags opened this issue Feb 15, 2018 · 3 comments · Fixed by #13234
Closed

sometimes back button stops working until restart #13157

LaurenWags opened this issue Feb 15, 2018 · 3 comments · Fixed by #13234

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Feb 15, 2018

Test Plan

Description

Reported by @mandar-brave on 0.20.42 the Back button stopped working. Restart of Brave resolved the issue.

Steps to Reproduce

  1. Use Brave for some time.
  2. Try to use back/forward buttons.

Actual result:
Back/Forward buttons stop working. Errors in console. Must restart Brave to resolve the issue.

Expected result:
Buttons should continue to function. No errors in console.

Reproduces how often:
unknown

Brave Version

about:brave info:
0.20.42

Reproducible on current live release:
reported with live release

Additional Information

There are a couple issues that happen intermittently and clear up with restart of Brave. #12828 was seen at the same time this issue was reported. Unsure but maybe also related to #12333 ?

@LaurenWags LaurenWags added the bug label Feb 15, 2018
@LaurenWags
Copy link
Member Author

+1s from community: https://community.brave.com/t/back-button-inconsistently-not-functional-after-browser-update-restart/16140

One user noted that they also encountered #12828 at the same time as this issue.

@LaurenWags LaurenWags added this to the 0.21.x (Beta Channel) milestone Feb 20, 2018
@LaurenWags
Copy link
Member Author

Also when this happens cmd+f stops working.

@bsclifton bsclifton self-assigned this Feb 20, 2018
@LaurenWags
Copy link
Member Author

+1 from community: https://community.brave.com/t/back-button-inconsistently-not-functional-after-browser-update-restart/16140/4

User also mentioned: "I notice when it happens I usually am unable to open links with new tabs, trying both right clicking on the link or using the keyboard shortcut."

petemill added a commit that referenced this issue Feb 21, 2018
This was causing an error to be thrown for every subsequent action, and no more state updates to be sent to windows, resulting in multiple issues.
It was also causing an error dump to be generated upon every action, thus halting the browser at those times, including any audio/video (and creating stutters).

Fix #13079 (main test case with STR)
Fix #12333
Fix #12828
Fix #13157
Address #13087 but this is a broad issue - this change will fix a hard issue, whereas that refers to general slowness.
@bsclifton bsclifton assigned petemill and unassigned bsclifton Feb 21, 2018
bsclifton pushed a commit that referenced this issue Feb 21, 2018
This was causing an error to be thrown for every subsequent action, and no more state updates to be sent to windows, resulting in multiple issues.
It was also causing an error dump to be generated upon every action, thus halting the browser at those times, including any audio/video (and creating stutters).

Fix #13079 (main test case with STR)
Fix #12333
Fix #12828
Fix #13157
Address #13087 but this is a broad issue - this change will fix a hard issue, whereas that refers to general slowness.
@bsclifton bsclifton modified the milestones: 0.22.x (Developer Channel), 0.20.x Release 3 (Hotfix) Feb 25, 2018
ryanml pushed a commit to ryanml/browser-laptop that referenced this issue Feb 27, 2018
This was causing an error to be thrown for every subsequent action, and no more state updates to be sent to windows, resulting in multiple issues.
It was also causing an error dump to be generated upon every action, thus halting the browser at those times, including any audio/video (and creating stutters).

Fix brave#13079 (main test case with STR)
Fix brave#12333
Fix brave#12828
Fix brave#13157
Address brave#13087 but this is a broad issue - this change will fix a hard issue, whereas that refers to general slowness.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.