Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

after 0.20.x update Brave is slow/sluggish #13087

Closed
LaurenWags opened this issue Feb 9, 2018 · 18 comments
Closed

after 0.20.x update Brave is slow/sluggish #13087

LaurenWags opened this issue Feb 9, 2018 · 18 comments
Assignees
Labels
0.20.x issue first seen in 0.20.x bug perf priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include usability

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Feb 9, 2018

Test Plan

Description

Reports of Brave being slow/sluggish/lagging after update to 0.20.x. Some users are experiencing slowness immediately after opening (@Jacalz on Windows 10) others are seeing the slowness after having Brave open for several days (@davidtemkin and @kjozwiak on MacOS). Sometimes a restart fixes the problem.

Steps to Reproduce

STR seem to vary: some users experience this immediately and others have had Brave open and operating normally for a few days.

Actual result:
Slowness and lagging

Expected result:
No changes to browsing experience

Reproduces how often:
Unknown

Brave Version

about:brave info:
0.20.30

Reproducible on current live release:
Yes

Additional Information

Could be related to #13079

@LaurenWags LaurenWags added bug perf 0.20.x issue first seen in 0.20.x labels Feb 9, 2018
@Jacalz
Copy link
Contributor

Jacalz commented Feb 9, 2018

Has happened to me 2 times after just opening the browser and one time from using it for like 30 minutes.

@Jacalz
Copy link
Contributor

Jacalz commented Feb 9, 2018

Restart always fixed the problem for me on Windows:
Brave: 0.20.30
V8: 6.4.388.40
rev: 8b78402
Muon: 4.7.9
OS Release: 10.0.16299
Update Channel: Release
OS Architecture: x64
OS Platform: Microsoft Windows
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 64.0.3282.119

@kjozwiak kjozwiak added the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Feb 9, 2018
@cndouglas
Copy link

Maybe related: #13016

@hugobuddel
Copy link
Contributor

Maybe related, maybe not: Brave grinds to a halt (like taking seconds to register clicking on a tab) when it goes into a crash loop as described in #12995 and a restart fixes it. Perhaps other slowdowns are caused by similar crash loops?

@Jacalz
Copy link
Contributor

Jacalz commented Feb 9, 2018

@LaurenWags
Copy link
Member Author

@LaurenWags
Copy link
Member Author

@LaurenWags
Copy link
Member Author

@karolszafranski
Copy link

Same issue:

Brave: 0.20.30 
V8: 6.4.388.40 
rev: 8b78402e7b3b91d44d8146cbe4dc8013592c33fd 
Muon: 4.7.9 
OS Release: 16.7.0 
Update Channel: Release 
OS Architecture: x64 
OS Platform: macOS 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 64.0.3282.119

Is there a way how can we help to nail down the issue? Like enabling additional logging?

@benjibee
Copy link

This has been driving me crazy recently. Eventually YouTube playback is as slow as a first-gen MacBook Air and just today it's become all-together unresponsive at some point, new tabs open in the tab bar but never produce a window, clicking on inputs takes ages, etc. etc. Relaunching Brave does indeed fix the issues temporarily.

Brave: 0.20.30 
V8: 6.4.388.40 
rev: 8b78402e7b3b91d44d8146cbe4dc8013592c33fd 
Muon: 4.7.9 
OS Release: 17.4.0 
Update Channel: Release 
OS Architecture: x64 
OS Platform: macOS 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 64.0.3282.119

@djmaze
Copy link

djmaze commented Feb 13, 2018

When this problem occurs for me (on Linux), I can almost everytime see in the task manager that there is one of Brave's subprocesses (brave --type renderer ..) which takes up alnost 100% CPU. If I kill this process, Brave continues to run while, for the time being, the slowness goes away.

I hope Brave does not do cryptomining in the background..

Brave | 0.20.29
V8 | 6.4.388.40
rev | 4fc3c8f
Muon | 4.7.9
OS Release | 4.15.2-2-ARCH
Update Channel | Release
OS Architecture | x64
OS Platform | Linux
Node.js | 7.9.0
Brave Sync | v1.4.2
libchromiumcontent | 64.0.3282.119

@lukemulks
Copy link
Collaborator

I'm running into the issue as well.

Brave: 0.20.30 
V8: 6.4.388.40 
rev: 8b78402e7b3b91d44d8146cbe4dc8013592c33fd 
Muon: 4.7.9 
OS Release: 10.0.16299 
Update Channel: Release 
OS Architecture: x64 
OS Platform: Microsoft Windows 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 64.0.3282.119

brave-memory-win10-02122018

As opposed to relaunching Brave - if I close the lid on my laptop and re-open to wake the computer back up, it resolves the issue for 1-2 days before it is noticeable again.

@alexwykoff alexwykoff added this to the 0.21.x (Beta Channel) milestone Feb 13, 2018
@alexwykoff alexwykoff added the priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. label Feb 13, 2018
@calebv
Copy link

calebv commented Feb 13, 2018

Wanted to sound off hear as well. Experiencing very similar issues. Details:

Brave: 0.20.30
V8: 6.4.388.40
rev: 8b78402e7b3b91d44d8146cbe4dc8013592c33fd
Muon: 4.7.9
OS Release: 17.4.0
Update Channel: Release
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 64.0.3282.119
Machine: MacBook Pro (15-inch, 2016)
Processor: 2.9 GHz Intel Core i7
Memory: 16 GB 2133 MHz LPDDR3
OS: macOS High Sierra Version 10.13.3 (17D47)

Some days it takes only minutes for Brave to start slowing down, others it could take a couple hours, but it always seems to slow down at some point. Behavior results in an extreme lag in switching or opening new tabs (sometimes as long as 10 seconds, others shorter but still very noticeable). Additionally, I start to see even a delay in text recognition, where I will start typing and the browser isn't picking it up until after I've gotten halfway through a sentence. I haven't noticed any spike in CPU usage through Activity Monitor, but it does seem as though Brave begins to slow down all processes on my machine when it's begun to slow down.

@bsclifton
Copy link
Member

+1 from @LethalManBoob via #13016

There's not much more to it. I run brave for about 20 minutes and then
suddenly it runs at 3fps. A reboot being required. Cpu does spike and stay
at 30% on my 6700k though. I reinstalled and haven't had the issue since.
But it could happen at any moment so i dunno. I tried turning on and off
the experimental security option but no change.

My Brave Stats

Brave: 0.20.30
V8: 6.4.388.40
rev: 8b78402
Muon: 4.7.9
OS Release: 10.0.16299
Update Channel: Release
OS Architecture: x64
OS Platform: Microsoft Windows
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 64.0.3282.119

My system stats straight from my dxdiag text save file
https://pastebin.com/raw/XnAhvgZf

Also when i said reboot I meant relaunch the browser.

@bsclifton
Copy link
Member

I believe the majority of the impact for this issue was caused by recent changes to tab discarding.
#12917
#12977

@petemill is looking into this along with @bridiver. I've done some profiling of the app and haven't found any red flags in the code (yet)

@kevinp2
Copy link

kevinp2 commented Feb 15, 2018

I'm seeing the same issue on Windows 7. I think it may be related to a memory leak. This did not happen in earlier releases.

Brave 0.20.30
V8 6.4.388.40
rev 8b78402
Muon 4.7.9
OS Release 6.1.7601
Update Channel Release
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 64.0.3282.119

After having Brave open for some hours, it becomes unbearably slow. I noticed that the Brave.exe processes were consuming well over 1.5 GB of RAM. After closing all but one tab, and then changing that one tab to be about:blank, there were still three Brave.exe processes consuming 1.5GB of RAM! See the attached screeenshot.

bravememoryleak

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 20, 2018

STR

  1. start browser (make sure you have a folder with at least 20 bookmarks)
  2. open YouTube player
  3. right click on a folder and select Open all in tabs
  4. then immediately after they are opened start closing them with mouse middle button or cmd+w
  5. youtube starts lagging and then if you just click on a youtube page (on white section) video lags

petemill added a commit that referenced this issue Feb 21, 2018
This was causing an error to be thrown for every subsequent action, and no more state updates to be sent to windows, resulting in multiple issues.
It was also causing an error dump to be generated upon every action, thus halting the browser at those times, including any audio/video (and creating stutters).

Fix #13079 (main test case with STR)
Fix #12333
Fix #12828
Fix #13157
Address #13087 but this is a broad issue - this change will fix a hard issue, whereas that refers to general slowness.
bsclifton pushed a commit that referenced this issue Feb 21, 2018
This was causing an error to be thrown for every subsequent action, and no more state updates to be sent to windows, resulting in multiple issues.
It was also causing an error dump to be generated upon every action, thus halting the browser at those times, including any audio/video (and creating stutters).

Fix #13079 (main test case with STR)
Fix #12333
Fix #12828
Fix #13157
Address #13087 but this is a broad issue - this change will fix a hard issue, whereas that refers to general slowness.
@bsclifton
Copy link
Member

I believe the majority of this was solved with #13234

We'll definitely see some UI gain when #11515 is addressed

@bsclifton bsclifton modified the milestones: 0.22.x (Developer Channel), 0.20.x Release 3 (Hotfix) Feb 25, 2018
@kjozwiak kjozwiak added QA/test-plan-specified release-notes/include and removed needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. labels Feb 26, 2018
ryanml pushed a commit to ryanml/browser-laptop that referenced this issue Feb 27, 2018
This was causing an error to be thrown for every subsequent action, and no more state updates to be sent to windows, resulting in multiple issues.
It was also causing an error dump to be generated upon every action, thus halting the browser at those times, including any audio/video (and creating stutters).

Fix brave#13079 (main test case with STR)
Fix brave#12333
Fix brave#12828
Fix brave#13157
Address brave#13087 but this is a broad issue - this change will fix a hard issue, whereas that refers to general slowness.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.20.x issue first seen in 0.20.x bug perf priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include usability
Projects
None yet
Development

No branches or pull requests