Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Pressing tab on autocomplete suggestion doesn't fill the input field #7132

Closed
srirambv opened this issue Feb 8, 2017 · 4 comments
Closed

Comments

@srirambv
Copy link
Collaborator

srirambv commented Feb 8, 2017

Test Plan

  • Ensure you have auto complete suggestion for on an input filed
  • Press down on the input field to highlight the suggestion
  • Once highlighted press tab, field should be filled

original issue details

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Pressing tab on autocomplete suggestion doesn't fill the input field

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.13.2
    rev 25b1199

  • Steps to reproduce:

    1. Ensure you have auto complete suggestion for on an input filed
    2. Press down on the input field to highlight the suggestion
    3. Once highlighted press tab, field is still blank doesn't autocomplete
  • Actual result:
    Autocomplete suggestion doesn't fill in when tab is pressed

  • Expected result:
    Should put the auto complete suggestion in the input field when tab is pressed

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    N/A

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    tabselect

  • Any related issues:
    Autofill: can't select popup item using arrow keys #1302

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 8, 2017

This is not a bug, it's by design. You can see it here, enter selects the item and esc and tab closes it. Should we change it?

@bsclifton
Copy link
Member

Good question- @srirambv, @NejcZdovc what is the behavior in other browsers? I believe tab works... so I think it would make sense to also implement that too 😄

@srirambv
Copy link
Collaborator Author

srirambv commented Feb 8, 2017

@bsclifton Other browsers all auto complete suggestion gets selected on tab. This is standard behavior for auto complete.

Chrome behavior
7132

@NejcZdovc
Copy link
Contributor

Ok will fix it

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 8, 2017
Resovles brave#7132

Auditors: @srirambv @bsclifton

Test Plan:
- Ensure you have auto complete suggestion for on an input filed
- Press down on the input field to highlight the suggestion
- Once highlighted press tab, field should be filled
@NejcZdovc NejcZdovc self-assigned this Feb 8, 2017
@NejcZdovc NejcZdovc modified the milestones: 0.13.3, 0.13.4 Feb 8, 2017
bsclifton added a commit that referenced this issue Feb 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.