Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Ledger pin publishers 0 for unpinned sites #9641

Closed
NejcZdovc opened this issue Jun 21, 2017 · 2 comments
Closed

Ledger pin publishers 0 for unpinned sites #9641

NejcZdovc opened this issue Jun 21, 2017 · 2 comments

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jun 21, 2017

Test plan

See below


  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    When you exclude all unpinned sites, pinned sites should have total of 100. Found while doing Local failing tests #9638

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version (revision SHA):
    63ff18d

  • Steps to reproduce:

    1. Enable ledger
    2. Visit two pages
    3. Go to payments
    4. Pin one publisher
    5. Exclude second one
  • Actual result:
    First publisher has the same value as before

  • Expected result:
    First publisher should have 100%

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    yes

  • Is this an issue in the currently released version?

  • Can this issue be consistently reproduced?
    yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:

@NejcZdovc NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 21, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 21, 2017
@NejcZdovc
Copy link
Contributor Author

So the problem is that exclude is not updated, so when you click exclude calculator in ledger doesn't have this information yet, but if you then click on input and out everything will be updated correctly.

@alexwykoff alexwykoff modified the milestones: 0.20.x (Developer Channel), 0.19.x (Beta Channel), 0.21.x (Nightly Channel) Jul 18, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 27, 2017
@NejcZdovc
Copy link
Contributor Author

When this is fixed re-enable test for it, disabled in #10168

NejcZdovc added a commit that referenced this issue Jul 27, 2017
Skips ledger pin test until #9641 is fixed
@bbondy bbondy mentioned this issue Jul 27, 2017
21 tasks
@ghost ghost added the sprint/1 label Sep 13, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 18, 2017
Resolves brave#9641

Auditors:

Test Plan:
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Nightly Channel), 0.19.x (Beta Channel) Sep 20, 2017
@NejcZdovc NejcZdovc mentioned this issue Sep 26, 2017
27 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.