This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Disable password autofill upon page load #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i don't have a working muon build right now but lgtm otherwise |
darkdh
force-pushed
the
browser-laptop-issue-12489
branch
from
dacc953
to
a1b3336
Compare
bridiver
reviewed
Jan 4, 2018
| @@ -36,6 +36,7 @@ | |||
| #include "chrome/common/chrome_paths.h" | |||
| #include "chrome/common/chrome_result_codes.h" | |||
| #include "chrome/common/chrome_switches.h" | |||
| #include "components/password_manager/core/common/password_manager_features.h" | |||
There was a problem hiding this comment.
is there already a dep for this in the target for atom_browser_main_parts.cc?
There was a problem hiding this comment.
no, it will fail to find the definition if I remove the header
darkdh
force-pushed
the
browser-laptop-issue-12489
branch
from
a1b3336
to
d7fdca0
Compare
bridiver
added a commit
that referenced
this pull request
Jan 4, 2018
Disable password autofill upon page load
bridiver
added a commit
that referenced
this pull request
Jan 4, 2018
Disable password autofill upon page load
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/browser-laptop#12489
Auditors: @bridiver, @diracdeltas, @bbondy