This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Do not prompt users to save password on passphrase confirmation page #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix brave/browser-laptop#12563 Auditors: @bridiver, @diracdeltas Test plan: 1. Make sure built-in password manager is enabled 2. Male sure passphrase is set on trezor wallet 3. Plugin trezor and open wallet 4. Type passphrase and submit 5. Brave shouldn't prompt any messages to save password 1. Make sure built-in password manager is enabled 2. Sign up account for https://trac.torproject.org 3. Brave should ask users to save password, click deny 4. Logout and Login 5. Brave should ask users to save password, click allow 6. Change password 7. Brave should ask users to update password, click allow 8. Logout and use the save credentials to login 9. It should be able to login sucessfully
|
defer to @bridiver since my mac builds still aren't working but lgtm |
bridiver
approved these changes
Jan 10, 2018
bridiver
added a commit
that referenced
this pull request
Jan 10, 2018
Do not prompt users to save password on passphrase confirmation page
bridiver
added a commit
that referenced
this pull request
Jan 10, 2018
Do not prompt users to save password on passphrase confirmation page
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/browser-laptop#12563
Auditors: @bridiver, @diracdeltas
Test plan:
a.
b.