Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hydration exceptions as events #14

Merged
merged 2 commits into from
Apr 16, 2015
Merged

fix: hydration exceptions as events #14

merged 2 commits into from
Apr 16, 2015

Conversation

trq
Copy link
Member

@trq trq commented Apr 16, 2015

Adds another catch point

@trq
fix: hydration exceptions as events
52e0519 
Adds another catch point
@purinda
Copy link
Member

purinda commented Apr 16, 2015

👍

@jordonsc
Copy link
Member

For the sake of slightly less code replication, what if you moved the if statement inside the catch block, with the else block containing a throw $e;.

@nedimdzendzo
Copy link
Contributor

👍

nedimdzendzo added a commit that referenced this pull request Apr 16, 2015
@nedimdzendzo
Merge pull request #14 from bravo3/fix/hydration-exceptions-as-events
ec253e0 
fix: hydration exceptions as events
@nedimdzendzo nedimdzendzo merged commit ec253e0 into master Apr 16, 2015
@nedimdzendzo nedimdzendzo deleted the fix/hydration-exceptions-as-events branch April 16, 2015 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trq @purinda @jordonsc @nedimdzendzo