Support for PubSub Messaging #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added PubSubEvent for passing messages back and forth between the publisher and subscriber.
Predis client. Added a PubSubManager for handling events. Added initial tests which are WIP.
and implemented a WIP custom subscriber function in the RedisDriver.
Fixed an issue with extracting channel name. Bit of refactoring.
Fixed DummyPubSubDriver for unit testing.
| @@ -91,6 +92,10 @@ public function __construct( | |||
| $this->client = $client; | |||
| } | |||
|
|
|||
| // Enable Pub/Sub mechanism | |||
| if ($this->isPubSubSupported()) { | |||
|
|
||
| // Send the message to the subscriber | ||
| $pubsub_manager->addListener($channel_name, function(PubSubEvent $e) { | ||
| list($cmd, $msg) = explode(' ', $e->getMessage()); |
There was a problem hiding this comment.
Just an example @y2khjh, in that example you can't.
| * @param string $message | ||
| * @return int | ||
| */ | ||
| public function publishMessage($channel, $message); |
There was a problem hiding this comment.
Explain a bit more? Unit tests should be for the driver, which we assume works as it is from Predis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pub/Sub
Pub/Sub mechanism implements the message passing between applications using the ORM leveraging the native implementations of Pub/Sub within the database driver in use.
An example use case for Pub/Sub would be sending messages to background tasks that run on a separate process apart from the application itself, processing the workload without holding the application process.