-
Notifications
You must be signed in to change notification settings - Fork 0
TODO
brutal-chaos edited this page Dec 13, 2014
·
3 revisions
-
Accept all client versions 1.0 - 1.8.1+
-
Default versions from the releases drop down in the launcher
-
If a protocol version is not implemented, kick the client with a version specific message
-
A basic skeleton is needed for each supported protocol version
-
This will consist of a handshake and kick protocol / packet structure
-
Complete test coverage.
-
RECOMMENDED: Write tests first, commit them, write code to make tests pass
-
If it's not as simple as 1+1 - write a test
-
If no tests are provided in your pull request, automatic refusal
-
TDD with Twisted: http://twistedmatrix.com/documents/current/core/howto/trial.html
-
http://twistedmatrix.com/documents/current/core/howto/testing.html
-
All code must pass pyflakes and pep8
-
Pre-commit hook will run flake8
- If possible, keep as much of the bravo plugin structure as possible and bring over plugins