Update redis gems #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonpenny
commented
May 2, 2024
| @@ -3,9 +3,9 @@ source "https://rubygems.org" | |||
| gemspec | |||
|
|
|||
| gem "rake" | |||
| gem "redis-namespace", github: "resque/redis-namespace", branch: :master | |||
| gem "redis-namespace", "1.11.0" | |||
There was a problem hiding this comment.
This is the version that platform is targeting to upgrade to
| gem "rails", ">= 6.0.2" | ||
| gem "sqlite3", platforms: :ruby | ||
| gem "sqlite3", "~> 1.7", platforms: :ruby |
There was a problem hiding this comment.
This allows gemtester to work, so it seems good to do here (the Gemfile gets used for CI/tests only)
mattwd7
reviewed
May 29, 2024
mattwd7
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates our fork for some upstream changes that are required for
platformto use a newer version of theredisgemThis also updates our fork repo to be able to run
bundle exec rakelocally to run all the testsfor use in
platform:Includes (modified code from) these upstream PRs:
Redis#pipelinedandRedis#multisidekiq/sidekiq#5139