Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redis gems #4

Merged
merged 9 commits into from
Jul 15, 2024
Merged

Update redis gems #4

merged 9 commits into from
Jul 15, 2024

Conversation

jasonpenny
Copy link

@jasonpenny jasonpenny commented May 2, 2024

Updates our fork for some upstream changes that are required for platform to use a newer version of the redis gem

This also updates our fork repo to be able to run bundle exec rake locally to run all the tests

for use in platform:


Includes (modified code from) these upstream PRs:

@@ -3,9 +3,9 @@ source "https://rubygems.org"
gemspec

gem "rake"
gem "redis-namespace", github: "resque/redis-namespace", branch: :master
gem "redis-namespace", "1.11.0"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the version that platform is targeting to upgrade to

gem "rails", ">= 6.0.2"
gem "sqlite3", platforms: :ruby
gem "sqlite3", "~> 1.7", platforms: :ruby
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows gemtester to work, so it seems good to do here (the Gemfile gets used for CI/tests only)

@jasonpenny jasonpenny marked this pull request as ready for review May 29, 2024 15:25
@jasonpenny jasonpenny requested a review from a team May 29, 2024 15:25
lib/sidekiq/client.rb Show resolved Hide resolved
lib/sidekiq/fetch.rb Show resolved Hide resolved
@jasonpenny jasonpenny merged commit bfa4e01 into feature-braze-changes Jul 15, 2024
@jasonpenny jasonpenny deleted the update-redis-gems branch July 15, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants