-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building with meson yields "Unknown Compiler: javac" after it finds javac #73
Comments
I suffer the same issue here: I am not interested in the Java interface in that case. Is there a workaround to skip that check without patching the Rubberband source? |
I didn't understand this either, until I saw the notes in the bug filed to Meson (mesonbuild/meson#10900) So there is a There is another proposal (https://todo.sr.ht/~breakfastquay/rubberband/25) to switch to specifying Java as an additional optional project language and letting Meson sort it out, rather than looking up the tools one by one. I don't know whether that would fare any better. Perhaps not, because this failure actually occurs in magic Meson logic, not in my own scripted logic. Meson is taking control when I request the I can't think of any workaround that doesn't involve modifying Given how fragile this has turned out, it was undoubtedly a mistake to make building the JNI interface automatic - it should have been left opt-in as very few people use it. Unfortunately, when it was opt-in, it was so little exercised that it actually didn't build at all in the 3.0.0 release, which is the main reason I made it automatic in the first place - so that my own builds and CI exercises would pick it up where possible. But I can always script that as an additional build test instead. |
I submitted that patch after testing that it succeeded at configuring, when my mocking stub for javac (that successfully returns without reporting sensible information as a compiler, but is found as a "program") had failed with the mentioned error. Basically what happens is that the jni dependency requires you have java as a project language, and somewhat unusually, it goes ahead and adds it for you if you don't have it already. This is very possibly a bug... ... and then it does so in required mode, even if the jni dependency was optional. This is unquestionably a Meson bug. But, attempting to |
I pushed the fix from Eli (a week ago) and it seems to have been happily accepted by CI environments and the like. If anyone would like to test it before it gets tagged for a new release, now's the time! Otherwise I'll put out a minor release, perhaps tomorrow, with only this fix in it. Thanks! |
Right-o, it's out as 3.1.1. Thanks everyone! |
I am trying to compile rubberband using meson.
I get the following error:
coming from these lines in the meson.build:
I don't understand why if it's finding jar and javac it's then giving the unknown compiler error.
The text was updated successfully, but these errors were encountered: