Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rubberband] Update to 3.1.1 #27114

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Conversation

daschuer
Copy link
Contributor

@daschuer daschuer commented Oct 6, 2022

Describe the pull request

  • What does your PR fix?

    Updates to the latest upstream release

  • Which triplets are supported/not supported? Have you updated the CI baseline?

No change

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

github-actions[bot]
github-actions bot previously approved these changes Oct 6, 2022
@FrankXie05 FrankXie05 added the category:port-update The issue is with a library, which is requesting update new revision label Oct 8, 2022
@FrankXie05
Copy link
Contributor

@daschuer
Error log from config-x64-osx-dbg-out.log.
https://dev.azure.com/vcpkg/public/_build/results?buildId=78973&view=artifacts&pathAsName=false&type=publishedArtifacts

../src/v3.1.0-883b0dd07c.clean/meson.build:139:2: ERROR: Unknown compiler "javac"

config-x64-osx-dbg-out.log

@daschuer
Copy link
Contributor Author

Homebrew has fixed it by installing openjdk:
Homebrew/homebrew-core#112467

This is the Meson bug:
mesonbuild/meson#10900

@FrankXie05 FrankXie05 added the depends:upstream-changes Waiting on a change to the upstream project label Oct 14, 2022
@JoergAtGithub
Copy link
Contributor

This issue is fixed upstream now! A new bugfix release 3.1.1 of Rubberband containing the fix for this issue is out:
https://github.com/breakfastquay/rubberband/releases/tag/v3.1.1

@FrankXie05
Copy link
Contributor

@daschuer Now we can proceed with this PR. :)

@daschuer daschuer changed the title [rubberband] Update to 3.1.0 [rubberband] Update to 3.1.1 Nov 1, 2022
@FrankXie05 FrankXie05 added info:reviewed Pull Request changes follow basic guidelines and removed depends:upstream-changes Waiting on a change to the upstream project labels Nov 2, 2022
@BillyONeal BillyONeal merged commit 893bc1d into microsoft:master Nov 2, 2022
@BillyONeal
Copy link
Member

Thanks!

Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Nov 2, 2022
@daschuer daschuer deleted the rubberband_3.1.0 branch January 5, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants