Scheduling renewals #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcgruenhage
force-pushed
the
renewal-scheduling
branch
3 times, most recently
from
d3b0804
to
c56faeb
Compare
breard-r
reviewed
Apr 8, 2023
Thank you! 😄
|
jcgruenhage
force-pushed
the
renewal-scheduling
branch
from
c56faeb
to
af17ed7
Compare
Let's Encrypt suggests in the integration guide, that for spacing out renewals after issueing a lot of new certificates in a batch, you renew a few of them a bit early until it's evened out. This adds a config option that allows to set a timeframe in which early random delays are attempted.
This is in line with the recommendations of the Let's Encrypt integration guide, and the default most other clients implement as well.
jcgruenhage
force-pushed
the
renewal-scheduling
branch
from
af17ed7
to
9502acf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #74.
I've split the work here into three commits for easier reviewing/reasoning:
simplifies the code a bit, and makes the changes required in the next commit
a ton easier. Should also perform a tiny bit better.
work on.
EDIT: @breard-r I've only checked the contribution guide again after opening this PR, and noticed one thing I've not done "right": I've added a dependency, on
rand. I'd assume that's okay though?If adding a dependency is not okay, it'd be possible to start gating some of the features behind cargo feature flags and disable them by default. Where this would also make sense is #81, which will definitely pull in a lot more dependencies.