Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make http requests async, switch from attohttpc to reqwest #82

Merged
merged 2 commits into from
Apr 15, 2023

Conversation

jcgruenhage
Copy link
Contributor

@jcgruenhage jcgruenhage commented Apr 8, 2023

This is not tested properly yet. I've run cargo clippy and cargo test on
it, but I've not actually tried it out in a real deployment yet. It should
probably be fine though, considering this compiles :P

Does this need a changelog update as well? It already mentions "Manual
(and badly designed) threads have been replaced by async." under
unreleased, so I'd see this as just a small follow-up to that.

@breard-r
Copy link
Owner

Thank you! I don't think a changelog update is needed for this one, as you noted it's already included in the async part.

@breard-r breard-r merged commit 6b51a7f into breard-r:main Apr 15, 2023
@jcgruenhage jcgruenhage deleted the async-http branch April 15, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants