When rendering template params, insert name by parsing #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobandersen
force-pushed
the
insert_name_by_parsing
branch
2 times, most recently
from
0b8fa7f
to
5edbf0a
Compare
vermeeren
approved these changes
Apr 23, 2021
vermeeren
force-pushed
the
insert_name_by_parsing
branch
from
5edbf0a
to
c81353e
Compare
Uses internals in the C++ domain. Needs Sphinx 4.1. Fixes breathe-doc#652
vermeeren
force-pushed
the
insert_name_by_parsing
branch
from
c81353e
to
04235ae
Compare
michaeljones
pushed a commit
that referenced
this pull request
Apr 23, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #652, when Sphinx 4.1 is used (currently the 4.x branch, see https://github.com/sphinx-doc/sphinx/milestone/100). Thus, this PR implicitly depends on #676.
Uses internals in the C++ domain to parse the type and then inject the declname.