fix: handle worker termination after worker exit #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
closeWorkerAfterMs
causes for the worker to be terminated after the specified time. However, if the worker completes and exits normally beforecloseWorkerAfterMs
milliseconds, the timeout created upon worker init is not cleared. This causes aTypeError
wherethis.workers[name]
is undefined and thusthis.workers[name].terminate
cannot be read or called. This PR adds a check upon timeout to ensure thatthis.workers[name]
exists before callingterminate
. This PR also fixes the test caserun > job terminates after set time
, which was not actually a proper test since thePromise
in the test case was notawait
ed. The test failed to ensure that a worker that was properly terminated when termination was disabled.I realized during the fix that there is a generic
stop
function that performs several cleanup tasks, one of which is clearing the timout set bycloseWorkerAfterMs
. I wasn't sure if it was appropriate to callstop
during the exit stage of the worker, since the worker would technically already be stopped, so I leave it up to the maintainers to advise.