-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
included tsconfig-paths in worker.js #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please fix linting |
also you need to add a peerDepedency for tsconfig-paths. |
Fixed linting and added peerDeps :) |
Since this is TS I'll let you handle @shadowgate15 😏 |
can you also added it as a devDep @kgkg? |
and also for those peer deps lets use ">=NUM" |
can you update lockfile? |
nvm I'll take care of it. |
Great news, thank you 🎉 |
@shadowgate15 unfortunately doesn't work with npm :/
Probably needs to be ">=3 <4" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this PR adds tsconfig-paths registration to worker.
I've tested it with my current project using tsconfig-paths and it seems to work without issues.
It's just one-liner so if you could please merge it as fast as you can I would be very grateful 👍
Cheers!