Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

included tsconfig-paths in worker.js #3

Merged
merged 4 commits into from
Jan 20, 2022
Merged

Conversation

kgkg
Copy link
Contributor

@kgkg kgkg commented Jan 20, 2022

Hello,

this PR adds tsconfig-paths registration to worker.
I've tested it with my current project using tsconfig-paths and it seems to work without issues.

It's just one-liner so if you could please merge it as fast as you can I would be very grateful 👍

Cheers!

@niftylettuce
Copy link

Please fix linting

@shadowgate15
Copy link
Member

also you need to add a peerDepedency for tsconfig-paths.

@kgkg
Copy link
Contributor Author

kgkg commented Jan 20, 2022

Fixed linting and added peerDeps :)

@niftylettuce
Copy link

Since this is TS I'll let you handle @shadowgate15 😏

@shadowgate15
Copy link
Member

can you also added it as a devDep @kgkg?

@shadowgate15
Copy link
Member

and also for those peer deps lets use ">=NUM"

@shadowgate15
Copy link
Member

can you update lockfile?

@shadowgate15
Copy link
Member

nvm I'll take care of it.

@shadowgate15 shadowgate15 merged commit cb5b748 into breejs:main Jan 20, 2022
@shadowgate15
Copy link
Member

@kgkg
Copy link
Contributor Author

kgkg commented Jan 20, 2022

Great news, thank you 🎉

@kgkg
Copy link
Contributor Author

kgkg commented Jan 20, 2022

@shadowgate15 unfortunately doesn't work with npm :/

$ npm install @breejs/ts-worker
npm ERR! code EINVALIDTAGNAME
npm ERR! Invalid tag name ">=3<4": Tags may not have any characters that encodeURIComponent encodes.

Probably needs to be ">=3 <4"

@shadowgate15
Copy link
Member

fixed https://github.com/breejs/ts-worker/releases/tag/v1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants