Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsps2: implement lsps2.get_versions #115

Merged
merged 1 commit into from
Aug 21, 2023
Merged

lsps2: implement lsps2.get_versions #115

merged 1 commit into from
Aug 21, 2023

Conversation

JssDWt
Copy link
Collaborator

@JssDWt JssDWt commented Aug 11, 2023

First implementation of an lsps2 server method.
https://github.com/BitcoinAndLightningLayerSpecs/lsp/tree/main/LSPS2#0-api-version

#106

NOTE: points at lsps0 branch for now, to show the diff, because it depends on #114

Order of pull requests:

  1. Lsps0 implementation #114
  2. (this PR) lsps2: implement lsps2.get_versions #115
  3. Implement lsps2.get_info #116
  4. Implement lsps2.buy #120

@JssDWt JssDWt mentioned this pull request Aug 18, 2023
@JssDWt JssDWt changed the base branch from lsps0 to lsps2 August 21, 2023 08:02
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JssDWt JssDWt merged commit af03f8b into lsps2 Aug 21, 2023
36 checks passed
@JssDWt JssDWt deleted the lsps2-getversions branch October 17, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants