Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Htlc intercept greenlight #2

Closed
wants to merge 52 commits into from
Closed

Conversation

vyomeshaudi6
Copy link

intercept for greenlight and lnd instance together. lnd need to be tested.

@roeierez
Copy link
Member

@vyomeshaudi6 thanks for the PR and I am excited to get this going.
I think we need to organize the code a bit so it would be ready for handling two different LSPDs. For now let's assume they are not running simultaneously but if we design it right I think the move to running simultaneously would be easy as just different port of grpc to each of them, but this is later.
For now these are the structural changes that I see we need:

The original server.go contained all the LND logic, so I think we should not mix c-lightning logic with LND at this stage. One option is to

  1. Rename the file to lnd_lspd.go with run method instead of main
  2. Add clightning_lspd.go with run method that initialize the plugin and clightning stuff.
  3. Then we can add a main.go that using a configuration flag to know which server to run.

The main file can handle also the generate keys if needed.
As the implementation gain progress we will see if some re-use is needed.

@vyomeshaudi6 vyomeshaudi6 removed the request for review from yaslama June 13, 2022 12:38
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! a small comment regarding env variable.

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vyomeshaudi6 small comments and other than that Looks good to me.
We'll wait for @yaslama to review as well.

clightning_lspd.go Outdated Show resolved Hide resolved
clightning_lspd.go Outdated Show resolved Hide resolved
sample.env Outdated Show resolved Hide resolved
sample.env Outdated Show resolved Hide resolved
sample.env Outdated Show resolved Hide resolved
sample.env Outdated Show resolved Hide resolved
cln_lspd.go Outdated Show resolved Hide resolved
cln_lspd.go Outdated Show resolved Hide resolved
@JssDWt
Copy link
Collaborator

JssDWt commented Dec 3, 2022

Closing this in favor of #22

@JssDWt JssDWt closed this Dec 3, 2022
@JssDWt JssDWt deleted the htlc-intercept-greenlight branch August 13, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants