-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Htlc intercept greenlight #2
Conversation
@vyomeshaudi6 thanks for the PR and I am excited to get this going. The original server.go contained all the LND logic, so I think we should not mix c-lightning logic with LND at this stage. One option is to
The main file can handle also the generate keys if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! a small comment regarding env variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vyomeshaudi6 small comments and other than that Looks good to me.
We'll wait for @yaslama to review as well.
e005367
to
9012522
Compare
Closing this in favor of #22 |
intercept for greenlight and lnd instance together. lnd need to be tested.