APIGateway fixes #266
Merged
APIGateway fixes #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- always send "Accept: application/json" (this alters the API behavior: it no longer sends application/hal+json (which also uses ISO8601 timestamp instead of POSIX) and extends its GetResources output to include root resource id: https://github.com/boto/botocore/blob/c9e90ef5413bd560422e915d213df73ad88dffd7/tests/integration/test_apigateway.py#L32-L33)
|
|
||
| main :: IO () | ||
| main = do | ||
| lgr <- newLogger Trace stdout |
There was a problem hiding this comment.
Hate to bikeshed 
but maybe 4 spaces here, if only because the rest of the project is the same.
There was a problem hiding this comment.
Oops, indeed :)
Pushed again
|
👍 |
|
Let's merge? |
|
Kone4no! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out, APIGateway has two protocol modes,
Accept: application/hal+jsonandAccept: application/jsonwhere the latter is the one that's actually specified in the botocore spec.make -C release MODELS=model/apigatewaygenerates a thorough diff (updatedToHeadersfor every request), which is not included.The only reason I added a whole protocol to
genis to set the header becauserequestInstsmatches on the protocol. It probably makes sense to remove it to make the patch more lightweight, however earlier versions of the patch included a ton of changes for the timestamp format and for pulling the root resource id by parsing stuff in_linksbefore I realised I should try see what botocore does. (｡･ω..･)っ So let me know if you'd like the change to be done differently.