Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly catch exceptions in perform #464

Merged
merged 3 commits into from
May 25, 2018
Merged

Correctly catch exceptions in perform #464

merged 3 commits into from
May 25, 2018

Conversation

zyla
Copy link
Contributor

@zyla zyla commented May 24, 2018 •
edited
Loading

In perform, we don't want to finalize resources yet, but runResourceT does just that.

This patch reintroduces MonadCatch to AWSConstraint, and uses catches from MonadCatch instead of manually lifting/running ResourceT.

Fixes #463.

brendanhay
brendanhay approved these changes May 24, 2018
View reviewed changes
Copy link
Owner

@brendanhay brendanhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks

@zyla
Copy link
Contributor Author

zyla commented May 24, 2018

Updated issue number in PR description

@zyla
Copy link
Contributor Author

zyla commented May 24, 2018

Thanks for the fast response @brendanhay!

@brendanhay brendanhay merged commit 248f7b2 into brendanhay:develop May 25, 2018
@MichaelXavier
Copy link
Collaborator

@brendanhay It looks like tests are passing, Could we get a release?

@MichaelXavier
Copy link
Collaborator

Oh, and you might want to pull/revoke 1.6.0 after release.

@jdreaver jdreaver mentioned this pull request Jul 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendanhay brendanhay brendanhay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zyla @MichaelXavier @brendanhay