Parse more timezones #868
Merged
Parse more timezones #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endgame
force-pushed
the
parse-more-timezones
branch
from
27adcad
to
f3c7a40
Compare
It seems that AWS (maybe just S3?) can sometimes return RFC5322-format dates with an `obs-zone` other than "GMT", so widen our parser to accept them. A `%Z` in the format string causes `formatTime` to write the time zone as `UTC`, which is not a `zone` under RFC 822 nor an `obs-zone` in RFC 5322. We therefore split the `TimeFormat` class to distinguish between parsing and printing formats, so that we continue to emit the `obs-zone` of `GMT`.
endgame
force-pushed
the
parse-more-timezones
branch
from
d89d430
to
63e74ba
Compare
|
@hasufell please test this PR and let me know if it fixes your issue. |
endgame
force-pushed
the
parse-more-timezones
branch
from
42f24b3
to
63e74ba
Compare
I'm afraid I can't test this easily, because the libraries that I use don't build with amazonka HEAD and I don't have the time to invest in updating all that. Given that you have a test case using that exact date string, I guess it's probably fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the format string for RFC822 to use
%Zfor any timezone instead of the literalGMT. The use ofGMTin that format string goes as far back as I can trace (at least 8 years), so I'm surprised to see errors beginning now. Regardless, it's valid RFC 822 so let's support it.Fixes #866