Add a contributing guide and code of conduct #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johann150
reviewed
Sep 7, 2020
brendanzab
force-pushed
the
contributing-guide
branch
from
9de711d
to
1d75924
Compare
brendanzab
force-pushed
the
contributing-guide
branch
from
1d75924
to
5024e80
Compare
brendanzab
force-pushed
the
contributing-guide
branch
from
5024e80
to
e39fe68
Compare
brendanzab
force-pushed
the
contributing-guide
branch
from
3b4829c
to
93b4214
Compare
Johann150
reviewed
Sep 9, 2020
Johann150
reviewed
Sep 20, 2020
| 1. Create your contribution, meeting all [contribution quality standards](#quality-standards). | ||
| 1. Ensure all the tests pass (`cargo test`). | ||
| 1. [Create a pull request][create-a-pr] against the `master` branch of the repository. | ||
| 1. Once the pull request is reviewed and CI passes, it will be merged. |
There was a problem hiding this comment.
Should collaborators merge their own PRs or should they still be reviewed by someone else?
There was a problem hiding this comment.
Hmm, I think in general it's ok for collaborators to merge them themselves if they are approved. We could maybe look at adding Mergify or Bors support if this makes things easier?
There was a problem hiding this comment.
In other words, there are no other limitations than the last point and collaborators can merge themself if CI passes.
There was a problem hiding this comment.
I think an approved review is kind of like “I trust you to clean stuff up if I had any things I mentioned, but otherwise it looks good, merge when you're ready!”
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This begins work on a contributing guide, and adds a code of conduct.
I've documented my release process, but it's not the nicest. We might want to re-think it before we call #272 done, perhaps recommending
cargo-release?