Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown support for arguments #24

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

chvanam
Copy link
Contributor

@chvanam chvanam commented Aug 6, 2023

Pull request adding markdown support for arguments #20

  • Uses spatie/laravel-markdown's blade component to render HTML tags for markdown
  • The markdown HTML is styled using Tailwind's typography "prose" class, which is already present in Jetstream. Although a custom class can be used to have more control over the final styling.

Code highlighting is currently done on the client, exploring possibilities of having it on the server side instead but haven't found an easy solution yet.

Screenshot 2023-08-06 at 10 53 42

@brendt
Copy link
Owner

brendt commented Aug 7, 2023

This is great! Thank you :)

@brendt brendt merged commit db0334e into brendt:main Aug 7, 2023
@chvanam chvanam deleted the markdown-arguments branch August 8, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants