This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
remove import urllib.parse to stay compatible with python2 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivakumarp1988
approved these changes
Jun 19, 2020
The "import urllib.parse" was introduced with commit 50bba2a to fix requests containing an '&' character. But the class WebApi already used urllib.parse through the use of "from six.moves import urllib". The introduction of "import urllib.parse" made the module incompatible with Python2.
perlduck
force-pushed
the
drop-import-urllib-parse
branch
from
b3354dc
to
0487cd3
Compare
|
Thanks for the contribution and sorry for the late response. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "import urllib.parse" was introduced with commit 50bba2a to fix
requests containing an '&' character. But the class WebApi already
used urllib.parse through the use of "from six.moves import urllib".
The introduction of "import urllib.parse" made the module incompatible
with Python2.