Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify qname #41

Closed
ruqianl opened this issue Jul 12, 2019 · 3 comments
Closed

modify qname #41

ruqianl opened this issue Jul 12, 2019 · 3 comments

Comments

@ruqianl
Copy link

ruqianl commented Jul 12, 2019

Hi Brent,

I'm wondering if there is any easy way to modify a record.qname as I would like to add additional information to it.

Cheers,
Ruqian

@brentp
Copy link
Owner

brentp commented Jul 12, 2019

I agree this would be nice to have. But, it is actually not trivial as it requires updating the entire bam record. You can see how pysam does it here
I would gladly accept a PR for this. If not, I will have a look soon.

@brentp brentp closed this as completed in 8061691 Jul 12, 2019
@brentp
Copy link
Owner

brentp commented Jul 12, 2019

I went ahead and added this as set_qname(r:Record, qname:string)
please let me know any problems. Thanks for the suggestion.

@ruqianl
Copy link
Author

ruqianl commented Jul 14, 2019

Thanks for that, I tested that add it works well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants