-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing config file parameters #197
Comments
The recursion limit toggle is stored in the JSON configuration file. The output directory is not stored in the JSON configuration file. When developing this feature, I consciously made the decision to leave the output directory from the values being stored. This is because if someone uses the configuration file on a machine that did not create the config, the file could appear in an odd place by default. |
Fair point, may I suggest a golden middle way for your kind consideration ? A) when somebody set the output folder, a question popup to ask if the settings wish to be included in the config file. What do you think ? |
I think B is a good option - I will make sure to add some documentation for it also 👍 |
…files The output directory is not added automatically to an exported json file but this allows someone to add it manually and the UI to use the value on import.
@madtatu-development sorry for the delay, I have just put this change into develop. Are you able to try it out? You can add the output directory to {
"version": "auto-py-to-exe-configuration_v1",
"pyinstallerOptions": [
[Contents of array removed for brevity]
],
"nonPyinstallerOptions": {
"increaseRecursionLimit": true,
"manualArguments": "",
"outputDirectory": "C:\\Temp\\output" <--- like this
}
} |
Sorry for the slow response, happy to test it, as soon as I got home, latest by the end of this week. |
So, here I am BIG thanks for your patience! I had tested, but unless I am seriously overlooking something, it does not work yet, unfortunately. What I did:
Please have look at the screenshot: Did I overlook something ? |
@madtatu-development what branch are you using? |
This has not been put in the master branch yet as I was wanting to test first. In git, we have branches that point to different states of the codebase. This repos/codebases main branch is master, however if you change this to develop, it will contain the new changes to be tested, From here, you can download the repo as a zip (using the green button), reinstall auto-py-to-exe by first uninstalling your current version and then installing the version in the downloaded zip as outlined here. After installing the version in develop, it will be then ready to test. |
Oh, I see, terribly sorry, I never did this before. Thanks for explaining, I appreciate it! I did it as you instructed, and confirm, to be working perfectly!! AWESOME ! And huge help, big thanks for added this in!!!! Just for curiosity, to better understand how GIT works. Ss soon as you put it into master, all users will have this change when upgrading using pip install auto-to-py-exe --upgrade? This is super cool. So, if I want to get back to "normal" auto-to-py-exe after you added this change to master I have to uninstall this git version and install it again with PIP, correct ? |
No need to be sorry, a good learning experience. You nailed it with the master branch process setup (there is a bit more that works in the background but that is the flow) and going back to the normal version / version from PyPI. I'll merge the code in now and get a release out. |
Version 2.10.1 is now out: https://pypi.org/project/auto-py-to-exe/ |
Sweet awesomeness, THANK YOU!!! It was a HUGE HELP!! May I ask one last question ? Could you consider to add a CMD argument option (or any other way) to be able to call autopyexe with the json config file to automatically load config file at autopyexestartup ? Would be an amazing thing, for use, whom has to regenerate executable very often |
There already is:
To use this, execute |
SORRY, you right, I overlooked it. Many thanks, have a lovely day! |
These 2 settings are NOT stored in the json configuration file when set, and this would be great and useful:
The text was updated successfully, but these errors were encountered: