Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing config file parameters #197

Closed
madtatu-development opened this issue Sep 7, 2021 · 15 comments
Closed

Missing config file parameters #197

madtatu-development opened this issue Sep 7, 2021 · 15 comments
Assignees
Labels
enhancement New feature or request

Comments

@madtatu-development
Copy link

These 2 settings are NOT stored in the json configuration file when set, and this would be great and useful:

{36B7FB8F-D075-4C35-8DB1-D12149C33E82}

  • Possible you could add it ?
@brentvollebregt
Copy link
Owner

The recursion limit toggle is stored in the JSON configuration file.

The output directory is not stored in the JSON configuration file. When developing this feature, I consciously made the decision to leave the output directory from the values being stored. This is because if someone uses the configuration file on a machine that did not create the config, the file could appear in an odd place by default.

@madtatu-development
Copy link
Author

Fair point, may I suggest a golden middle way for your kind consideration ?

A) when somebody set the output folder, a question popup to ask if the settings wish to be included in the config file.
B) possibility to manually include this in config file by editing it, and if it is there, it is not ignored.

What do you think ?

@brentvollebregt
Copy link
Owner

brentvollebregt commented Sep 17, 2021

I think B is a good option - I will make sure to add some documentation for it also 👍

@brentvollebregt brentvollebregt self-assigned this Sep 17, 2021
@brentvollebregt brentvollebregt added the enhancement New feature or request label Sep 17, 2021
brentvollebregt added a commit that referenced this issue Sep 24, 2021
…files

The output directory is not added automatically to an exported json file but this allows someone to add it manually and the UI to use the value on import.
@brentvollebregt
Copy link
Owner

@madtatu-development sorry for the delay, I have just put this change into develop. Are you able to try it out?

You can add the output directory to nonPyinstallerOptions.outputDirectory, for example:

{
 "version": "auto-py-to-exe-configuration_v1",
 "pyinstallerOptions": [
    [Contents of array removed for brevity]
 ],
 "nonPyinstallerOptions": {
  "increaseRecursionLimit": true,
  "manualArguments": "",
  "outputDirectory": "C:\\Temp\\output"    <--- like this
 }
}

@madtatu-development
Copy link
Author

Sorry for the slow response, happy to test it, as soon as I got home, latest by the end of this week.

@madtatu-development
Copy link
Author

So, here I am BIG thanks for your patience!

I had tested, but unless I am seriously overlooking something, it does not work yet, unfortunately.

What I did:

  1. Copy the correct line from your post above
  2. I had manually edited autopyexe json config file and pase the copied line.
  3. I added an extra comma after the previous config line as shown above in your post
  4. started autopyexe and loaded the config file
  5. compared output directory input field

Please have look at the screenshot:

{A610DDC0-0C5B-4E27-9091-23DAD052BE7E}

Did I overlook something ?

@brentvollebregt
Copy link
Owner

@madtatu-development what branch are you using?

@madtatu-development
Copy link
Author

madtatu-development commented Oct 4, 2021

If I understood your question correctly:

image

@brentvollebregt
Copy link
Owner

This has not been put in the master branch yet as I was wanting to test first.

In git, we have branches that point to different states of the codebase. This repos/codebases main branch is master,

image

however if you change this to develop, it will contain the new changes to be tested,

image

From here, you can download the repo as a zip (using the green button), reinstall auto-py-to-exe by first uninstalling your current version and then installing the version in the downloaded zip as outlined here.

After installing the version in develop, it will be then ready to test.

@madtatu-development
Copy link
Author

madtatu-development commented Oct 4, 2021

Oh, I see, terribly sorry, I never did this before. Thanks for explaining, I appreciate it!

I did it as you instructed, and confirm, to be working perfectly!! AWESOME ! And huge help, big thanks for added this in!!!!

Just for curiosity, to better understand how GIT works. Ss soon as you put it into master, all users will have this change when upgrading using pip install auto-to-py-exe --upgrade? This is super cool.

So, if I want to get back to "normal" auto-to-py-exe after you added this change to master I have to uninstall this git version and install it again with PIP, correct ?

@brentvollebregt
Copy link
Owner

brentvollebregt commented Oct 5, 2021

No need to be sorry, a good learning experience. You nailed it with the master branch process setup (there is a bit more that works in the background but that is the flow) and going back to the normal version / version from PyPI.

I'll merge the code in now and get a release out.

@brentvollebregt
Copy link
Owner

Version 2.10.1 is now out: https://pypi.org/project/auto-py-to-exe/

@madtatu-development
Copy link
Author

Sweet awesomeness, THANK YOU!!! It was a HUGE HELP!!

May I ask one last question ?

Could you consider to add a CMD argument option (or any other way) to be able to call autopyexe with the json config file to automatically load config file at autopyexestartup ? Would be an amazing thing, for use, whom has to regenerate executable very often

@brentvollebregt
Copy link
Owner

There already is: --config. From the README:

Provide a configuration file (json) to pre-fill the UI. These can be generated in the settings tab.

To use this, execute auto-py-to-exe --config yourconfigfile.json.

@madtatu-development
Copy link
Author

SORRY, you right, I overlooked it. Many thanks, have a lovely day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants