Allow git2consul global package installation #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,6 +33,8 @@ | |||
| "should": "3.3.2", | |||
| "xunit-file": "0.0.5" | |||
| }, | |||
| "preferGlobal": true, | |||
There was a problem hiding this comment.
I think having the user explicitly pass in -g is a better option, which seems to be what you documented in the README.
There was a problem hiding this comment.
Indeed, the preferGlobal flag will only alert the user he should install it globally, but it will not cause any failure. ref: https://docs.npmjs.com/files/package.json#preferglobal
|
Can you also update the CHANGELOG to include this change? You can add it to v0.12.11. |
alexgervais
force-pushed
the
install.global
branch
from
72682ae
to
a81e08e
Compare
|
CHANGELOG updated. It does not reference a GH issue though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow you to install git2consul globally and have the
git2consulexecutable in path.